FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(radio/check): add support for optional description by boaz0 · Pull Request #3621 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(radio/check): add support for optional description - #3621

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3611
Jan 31, 2020
ConversationCommits (1)ChecksFiles changed
Merged

feat(radio/check): add support for optional description#3621
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_3611

Conversation

boaz0 commented Jan 30, 2020

Copy link
Copy Markdown
Member

What: Closes #3611

patternfly-build commented Jan 30, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3621.surge.sh

codecov-io commented Jan 30, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3621 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
+ Coverage   67.15%   67.17%   +0.01%     
==========================================
  Files         907      907              
  Lines       25559    25563       +4     
  Branches     2267     2269       +2     
==========================================
+ Hits        17165    17171       +6     
+ Misses       7353     7352       -1     
+ Partials     1041     1040       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.34% <100%> (+0.02%) ⬆️
#patternfly4integration ?
Impacted Files Coverage Δ
...-4/react-core/src/components/Checkbox/Checkbox.tsx 86.11% <100%> (+0.81%) ⬆️
...ernfly-4/react-core/src/components/Radio/Radio.tsx 94.73% <100%> (+5.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94364cb...397fa08. Read the comment docs.

dlabrecq previously approved these changes Jan 30, 2020
View reviewed changes
tlabaj requested a review from mcoker January 30, 2020 20:11
tlabaj suggested changes Jan 30, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add the new props to the demo app please.

feat(radio/check): add support for optional description
397fa08 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
mcoker approved these changes Jan 31, 2020
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍👍

jessiehuff approved these changes Jan 31, 2020
View reviewed changes

jessiehuff left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! :)

tlabaj approved these changes Jan 31, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit f4370fe into patternfly:master Jan 31, 2020
boaz0 deleted the closes_3611 branch February 1, 2020 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes
+3 more reviewers
jessiehuff jessiehuff approved these changes
tlabaj tlabaj approved these changes
dlabrecq dlabrecq left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Radio/check: support for optional description

7 participants

Back | FazBrowse Home | New Git URL