fix(Catalog Tile): Adjusted max width of header image - #3628
Merged
redallen merged 1 commit intoJan 30, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixing bug where badging wraps at two lines by shrinking down the max width of the provided image in the header.
Copy link
Copy Markdown
Collaborator
|
PF3 preview: https://patternfly-react-pr-3628-pf3.surge.sh |
Sorry, something went wrong.
jcaianirh
approved these changes
Jan 30, 2020
jcaianirh
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm thanks @rebeccaalpert
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3628 +/- ##
=======================================
Coverage 67.15% 67.15%
=======================================
Files 907 907
Lines 25567 25567
Branches 2266 2266
=======================================
Hits 17169 17169
Misses 7358 7358
Partials 1040 1040
Continue to review full report at Codecov.
|
Sorry, something went wrong.
redallen
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing bug where badging wraps at two lines when you have a wider wordmark. We're just shrinking down the max width of the provided image in the header here.