FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Catalog view extension): Many styles on examples stopped working by rebeccaalpert · Pull Request #3635 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Catalog view extension): Many styles on examples stopped working - #3635

Merged
redallen merged 1 commit into
patternfly:masterfrom
rebeccaalpert:catalog-tile-badgefix
Feb 3, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(Catalog view extension): Many styles on examples stopped working#3635
redallen merged 1 commit into
patternfly:masterfrom
rebeccaalpert:catalog-tile-badgefix

Conversation

rebeccaalpert commented Jan 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Many styles on examples stopped working. This change restores all styles on affected examples.

Changed classes to reflect the structure of the HTML, which appears to have changed.

Fixes #3633.

fix(Catalog view extension): Many styles on examples stopped working.…
b1272cf 
… This change restores all styles.

Changed classes to reflect new structure of HTML.

Fixes #3633
rebeccaalpert changed the title fix(Catalog view tile): All styles on examples stopped working. This … fix(Catalog view extension): Many styles on examples stopped working Jan 31, 2020

patternfly-build commented Jan 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3635-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3635.surge.sh
A11y report: https://patternfly-react-pr-3635-coverage.surge.sh

codecov-io commented Jan 31, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3635 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3635   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files         907      907           
  Lines       25567    25567           
  Branches     2266     2266           
=======================================
  Hits        17169    17169           
  Misses       7358     7358           
  Partials     1040     1040
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56c6fe...b1272cf. Read the comment docs.

jcaianirh approved these changes Feb 3, 2020
View reviewed changes

jcaianirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

redallen approved these changes Feb 3, 2020
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These changes should have been a part of when we moved these packages to extensions, sorry! Thanks for fixing them :)

redallen merged commit e1d176a into patternfly:master Feb 3, 2020
rebeccaalpert deleted the catalog-tile-badgefix branch February 3, 2020 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jcaianirh jcaianirh approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Catalog view tile, catalog tile header, and vertical tabs missing styles in examples

5 participants

Back | FazBrowse Home | New Git URL