FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(Demo): fixed the TextInput type in filter table demo by tlabaj · Pull Request #3652 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

docs(Demo): fixed the TextInput type in filter table demo - #3652

Merged
kmcfaul merged 1 commit into
patternfly:masterfrom
tlabaj:datatoolbar_textinput
Feb 5, 2020
ConversationCommits (1)ChecksFiles changed
Merged

docs(Demo): fixed the TextInput type in filter table demo#3652
kmcfaul merged 1 commit into
patternfly:masterfrom
tlabaj:datatoolbar_textinput

Conversation

tlabaj commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #3616

Additional issues:

tlabaj requested a review from dlabrecq February 4, 2020 16:30

patternfly-build commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3652-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3652.surge.sh
A11y report: https://patternfly-react-pr-3652-coverage.surge.sh

codecov-io commented Feb 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #3652 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3652   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files         907      907           
  Lines       25567    25567           
  Branches     2266     2266           
=======================================
  Hits        17169    17169           
  Misses       7358     7358           
  Partials     1040     1040
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fbc47...3ebeea8. Read the comment docs.

dlabrecq approved these changes Feb 4, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

kmcfaul merged commit ee43c73 into patternfly:master Feb 5, 2020

patternfly-build commented Feb 5, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.7
  • @patternfly/react-core@3.136.4
  • @patternfly/react-docs@4.18.9
  • @patternfly/react-inline-edit-extension@2.16.6
  • demo-app-ts@3.22.4
  • @patternfly/react-table@2.26.6
  • @patternfly/react-topology@2.13.6
  • @patternfly/react-virtualized-extension@1.3.102

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul kmcfaul approved these changes
+1 more reviewer
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filterable table demo: DataToolbar text input should use type="search"

5 participants

Back | FazBrowse Home | New Git URL