FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(docs): bump gatsby by redallen · Pull Request #3657 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(docs): bump gatsby - #3657

Merged
jschuler merged 1 commit into
patternfly:masterfrom
redallen:chore/bump-gatsby
Feb 5, 2020
ConversationCommits (1)ChecksFiles changed
Merged

chore(docs): bump gatsby#3657
jschuler merged 1 commit into
patternfly:masterfrom
redallen:chore/bump-gatsby

Conversation

redallen commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #3489

Additional issues: This should fix some reloading problems with the dev workspace. Remember to use Chrome!

evwilkin previously approved these changes Feb 4, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

patternfly-build commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3657-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3657.surge.sh
A11y report: https://patternfly-react-pr-3657-coverage.surge.sh

codecov-io commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3657 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3657   +/-   ##
=======================================
  Coverage   67.62%   67.62%           
=======================================
  Files         907      907           
  Lines       25939    25939           
  Branches     2269     2269           
=======================================
  Hits        17542    17542           
  Misses       7357     7357           
  Partials     1040     1040
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 65.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ae941...2398fec. Read the comment docs.

ddonahue007 approved these changes Feb 5, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler merged commit dc0f10e into patternfly:master Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin left review comments
jschuler Awaiting requested review from jschuler
kmcfaul Awaiting requested review from kmcfaul
seanforyou23 Awaiting requested review from seanforyou23
+3 more reviewers
dlabrecq dlabrecq approved these changes
jenny-s51 jenny-s51 approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'frontmatter' of null

8 participants

Back | FazBrowse Home | New Git URL