FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Slider): Add limit for lowest possible value of slider by rebeccaalpert · Pull Request #3660 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Slider): Add limit for lowest possible value of slider - #3660

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
rebeccaalpert:slider
Feb 6, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(Slider): Add limit for lowest possible value of slider#3660
dlabaj merged 1 commit into
patternfly:masterfrom
rebeccaalpert:slider

Conversation

rebeccaalpert commented Feb 5, 2020

Copy link
Copy Markdown
Member

When using the arrow keys to control the slider, it was possible to go below the set minimum value
on the slider. (-1 for a minimum of 0, 0 for a minimum of 1, and so on.) I added a minimum value check for the slider value.

Fixes #3187.

fix(Slider): Add limit for lowest possible value of slider
963f02a 
When using the arrow keys to control the slider, it was possible to go below the set minimum value
on the slider. I added a minimum value for the slider value.

Fixes #3187

patternfly-build commented Feb 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3660-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3660.surge.sh
A11y report: https://patternfly-react-pr-3660-coverage.surge.sh

codecov-io commented Feb 5, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3660 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3660      +/-   ##
==========================================
- Coverage   67.62%   67.61%   -0.01%     
==========================================
  Files         907      907              
  Lines       25939    25941       +2     
  Branches     2269     2269              
==========================================
- Hits        17542    17541       -1     
- Misses       7357     7360       +3     
  Partials     1040     1040
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.27% <50%> (-0.02%) ⬇️
#patternfly4 65.35% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...3/patternfly-react/src/components/Slider/Slider.js 55.84% <50%> (-2.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ae941...963f02a. Read the comment docs.

tlabaj approved these changes Feb 5, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 124210a into patternfly:master Feb 6, 2020

patternfly-build commented Feb 6, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@3.0.10
  • patternfly-react@2.39.14
  • @patternfly/react-console@2.0.13

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF3 Slider: onSlide does not strictly respect the minimum value

5 participants

Back | FazBrowse Home | New Git URL