chore(nomenclature): phrase non production components as beta - #3663
Conversation
Sorry, something went wrong.
|
PF3 preview: https://patternfly-react-pr-3663-pf3.surge.sh |
Sorry, something went wrong.
redallen
left a comment
There was a problem hiding this comment.
Looks like some file renaming went awry?
packages/patternfly-4/react-core/src/beta/components/DataToolbar/DataToolbar.test.tsx:13:53 - error TS2307: Cannot find module '../../../../components/Select'.
13 import { Select, SelectOption, SelectVariant } from '../../../../components/Select';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sorry, something went wrong.
redallen
left a comment
There was a problem hiding this comment.
CI is sad
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #3663 +/- ##
==========================================
- Coverage 71.26% 71.21% -0.05%
==========================================
Files 779 779
Lines 10489 10489
Branches 2261 2261
==========================================
- Hits 7475 7470 -5
Misses 2592 2592
- Partials 422 427 +5
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dgutride
left a comment
There was a problem hiding this comment.
Two big things - should we just import directly from react-core instead of the beta path to reduce changes down the road (and now that we can) and can the beta category be removed from the gatsby doc output yet?
Sorry, something went wrong.
dgutride
left a comment
There was a problem hiding this comment.
The experimental/index.ts barrel file needs to be added back as well (and export from ../beta/)
Sorry, something went wrong.
|
I've pushed some updates. We now display previously "experimental" components alongside all production components and visually mark them as "Beta" with an inline alert. This alert message needs to be reviewed.
In addition to now having the notion of beta components, we also have support for beta properties/features on production components. No beta properties exist yet, but below is a screenshot of how they are currently wired up to display. Notice the property name is exampleBetaProperty and the visual treatment is to simply prefix the property name with Beta: , just like we do for deprecated properties. We could style it some special way, or instead just generate a new "beta" column, but I figured a first pass would be good to follow the existing convention. #3581, which is in-progress, will put this new feature to use for the first time, I'm happy to address any changes now or later to this part of the experience.
|
Sorry, something went wrong.
mcarrano
left a comment
There was a problem hiding this comment.
@seanforyou23 just a couple things... The inline alert looks good. I checked out the Data toolbar page. However looks like there may be a problem pulling it the correct styles? The layout of this component is all messed up.
For tagging a property as Beta, is it possible to get closer to @rachael-phillips 's design using a badge?
Sorry, something went wrong.
|
Thanks @mcarrano - checking on the styles, think we just need to pull in a recent change from core. Good catch. As far as using a badge to flag beta properties, it shouldn't be a problem. I will take a look! |
Sorry, something went wrong.
|
Thx for the feedback @mcarrano - I pulled in the latest changes from core and that seems to have fixed the styles on the Data toolbar/Drawer beta component pages. Also, made some changes in an open PR in org that should better reflect the design @rachael-phillips provided for beta styles (sry, didn't see that before). Here's an example of what those changes across org/core produce: Marking examples as beta: And then marking props as beta in the props table at the bottom: Let me know if you see any issues! |
Sorry, something went wrong.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
What: Steps toward closing #3624
This PR renames "experimental" things to "beta" so that the intent of the in-progress status is more clearly signaled to users.