FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ContextSelector): Updated signature for context selector by dlabaj · Pull Request #3697 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(ContextSelector): Updated signature for context selector - #3697

Merged
redallen merged 1 commit into
patternfly:masterfrom
dlabaj:fix/issue3694
Feb 10, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(ContextSelector): Updated signature for context selector #3697
redallen merged 1 commit into
patternfly:masterfrom
dlabaj:fix/issue3694

Conversation

dlabaj commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

Updated signature for context selector to match what is returned.
fix #3694

patternfly-build commented Feb 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3697-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3697.surge.sh
A11y report: https://patternfly-react-pr-3697-coverage.surge.sh

codecov-io commented Feb 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3697 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3697   +/-   ##
=======================================
  Coverage   71.27%   71.27%           
=======================================
  Files         779      779           
  Lines       10488    10488           
  Branches     2261     2261           
=======================================
  Hits         7475     7475           
  Misses       2591     2591           
  Partials      422      422
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...src/components/ContextSelector/ContextSelector.tsx 71.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b7262...669134d. Read the comment docs.

tlabaj approved these changes Feb 7, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jcaianirh approved these changes Feb 7, 2020
View reviewed changes

jcaianirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

redallen merged commit bfd9958 into patternfly:master Feb 10, 2020

patternfly-build commented Feb 10, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.11
  • @patternfly/react-core@3.136.8
  • @patternfly/react-docs@4.18.13
  • @patternfly/react-inline-edit-extension@2.16.10
  • demo-app-ts@3.22.8
  • @patternfly/react-table@2.26.10
  • @patternfly/react-topology@2.13.10
  • @patternfly/react-virtualized-extension@1.3.106

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jcaianirh jcaianirh approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

seanforyou23

christiemolloy

jcaianirh

redallen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Context Selector signature for onToggle is wrong.

8 participants

Back | FazBrowse Home | New Git URL