FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(DataToolbar): update html structure to match core by kmcfaul · Pull Request #3710 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(DataToolbar): update html structure to match core - #3710

Merged
tlabaj merged 4 commits into
patternfly:masterfrom
kmcfaul:data-toolbar-html
Feb 13, 2020
ConversationCommits (4)ChecksFiles changed
Merged

feat(DataToolbar): update html structure to match core#3710
tlabaj merged 4 commits into
patternfly:masterfrom
kmcfaul:data-toolbar-html

Conversation

kmcfaul commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

What: Closes #3614

kmcfaul added the PF4 label Feb 10, 2020

patternfly-build commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3710-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3710.surge.sh
A11y report: https://patternfly-react-pr-3710-coverage.surge.sh

codecov-io commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3710 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3710   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         779      779           
  Lines       10491    10491           
  Branches     2263     2263           
=======================================
  Hits         7472     7472           
  Misses       2592     2592           
  Partials      427      427
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.13% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../src/components/DataToolbar/DataToolbarContent.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab8040...3690a95. Read the comment docs.

tlabaj requested a review from mattnolting February 11, 2020 15:10
dlabrecq previously approved these changes Feb 12, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, just need to update the snapshots

mattnolting reviewed Feb 12, 2020
View reviewed changes

mattnolting left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The structure has an added wrapper .pf-c-data-toolbar__content-section that separates expandable content from static content. I don't see it in the DOM.

<div class="pf-c-data-toolbar">
  <div class="pf-c-data-toolbar__content">
    <div class="pf-c-data-toolbar__content-section">

mattnolting previously approved these changes Feb 12, 2020
View reviewed changes

mattnolting left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see the changes now, Perfect!

dlabrecq previously approved these changes Feb 12, 2020
View reviewed changes
kmcfaul dismissed stale reviews from dlabrecq and mattnolting via 3690a95 February 12, 2020 19:53
tlabaj approved these changes Feb 13, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 6e61b1e into patternfly:master Feb 13, 2020

patternfly-build commented Feb 13, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.20
  • @patternfly/react-core@3.137.0
  • @patternfly/react-docs@4.19.0
  • @patternfly/react-inline-edit-extension@2.16.18
  • demo-app-ts@3.22.16
  • @patternfly/react-table@2.26.18
  • @patternfly/react-topology@2.13.19
  • @patternfly/react-virtualized-extension@1.3.114

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattnolting mattnolting left review comments
+2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(data-toolbar): structural update

6 participants

Back | FazBrowse Home | New Git URL