FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(build): use machine instance by redallen · Pull Request #3712 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(build): use machine instance - #3712

Merged
ddonahue007 merged 6 commits into
patternfly:masterfrom
redallen:fix/ci-costs
Feb 11, 2020
ConversationCommits (6)ChecksFiles changed
Merged

chore(build): use machine instance#3712
ddonahue007 merged 6 commits into
patternfly:masterfrom
redallen:fix/ci-costs

Conversation

redallen commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: We're downgrading to the free CircleCI plan soon.

Also enable lint:md in CI.

Additional issues:

redallen changed the title use machine instance chore(build): use machine instance Feb 10, 2020

patternfly-build commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3712-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3712.surge.sh
A11y report: https://patternfly-react-pr-3712-coverage.surge.sh

codecov-io commented Feb 10, 2020

Copy link
Copy Markdown

Codecov Report

Merging #3712 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3712   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files         779      779           
  Lines       10489    10489           
  Branches     2261     2261           
=======================================
  Hits         7470     7470           
  Misses       2592     2592           
  Partials      427      427
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c34a6f4...276aa16. Read the comment docs.

evwilkin approved these changes Feb 10, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin requested a review from ddonahue007 February 11, 2020 15:04
ddonahue007 suggested changes Feb 11, 2020
View reviewed changes
Comment thread .circleci/config.yml
ddonahue007 approved these changes Feb 11, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ddonahue007 merged commit 6d29660 into patternfly:master Feb 11, 2020

patternfly-build commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.14
  • @patternfly/react-core@3.136.11
  • @patternfly/react-docs@4.18.16
  • @patternfly/react-inline-edit-extension@2.16.13
  • demo-app-ts@3.22.11
  • @patternfly/react-table@2.26.13
  • @patternfly/react-topology@2.13.13
  • @patternfly/react-virtualized-extension@1.3.109

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
+1 more reviewer
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL