FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(react-charts): fixed linting errors by evwilkin · Pull Request #3713 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(react-charts): fixed linting errors - #3713

Merged
dlabrecq merged 5 commits into
patternfly:masterfrom
evwilkin:chore/lint-charts
Feb 14, 2020
ConversationCommits (5)ChecksFiles changed
Merged

chore(react-charts): fixed linting errors#3713
dlabrecq merged 5 commits into
patternfly:masterfrom
evwilkin:chore/lint-charts

Conversation

evwilkin commented Feb 10, 2020

Copy link
Copy Markdown
Member

What: Towards #3592 - resolves linting errors for react-charts

patternfly-build commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3713-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3713.surge.sh
A11y report: https://patternfly-react-pr-3713-coverage.surge.sh

codecov-io commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3713 into master will decrease coverage by <.01%.
The diff coverage is 45.33%.

@@            Coverage Diff             @@
##           master    #3713      +/-   ##
==========================================
- Coverage   71.22%   71.22%   -0.01%     
==========================================
  Files         779      779              
  Lines       10494    10490       -4     
  Branches     2265     2265              
==========================================
- Hits         7474     7471       -3     
  Misses       2594     2594              
+ Partials      426      425       -1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.12% <45.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...eact-charts/src/components/ChartLine/ChartLine.tsx 100% <ø> (ø) ⬆️
...harts/src/components/ChartScatter/ChartScatter.tsx 85.71% <ø> (ø) ⬆️
.../react-charts/src/components/ChartBar/ChartBar.tsx 100% <ø> (ø) ⬆️
...eact-charts/src/components/ChartArea/ChartArea.tsx 100% <ø> (ø) ⬆️
...ct-charts/src/components/ChartLabel/ChartLabel.tsx 83.33% <ø> (ø) ⬆️
.../react-charts/src/components/ChartPie/ChartPie.tsx 79.16% <ø> (-0.84%) ⬇️
...eact-charts/src/components/ChartAxis/ChartAxis.tsx 87.5% <ø> (ø) ⬆️
...ts/ChartDonutUtilization/ChartDonutUtilization.tsx 65.95% <ø> (ø) ⬆️
...ct-charts/src/components/ChartGroup/ChartGroup.tsx 85.71% <ø> (ø) ⬆️
...s/src/components/ChartThreshold/ChartThreshold.tsx 61.11% <ø> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae4fcb...cfa98f4. Read the comment docs.

evwilkin requested a review from dlabrecq February 10, 2020 21:42
dlabrecq suggested changes Feb 10, 2020
View reviewed changes

dlabrecq left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is it possible to apply linting changes without reorganizing such large blocks of code? It makes things very difficult to review and doesn't appear to be necessary.

Functions that were in alphabetical order now appear to have been moved randomly.

Moving large amounts of code around risks introducing new bugs. It's difficult to tell if the functionality remains intact, especially for the interactive legend?

Comment thread packages/patternfly-4/react-charts/src/components/ChartBullet/utils/chart-bullet-size.ts
Comment thread packages/patternfly-4/react-charts/src/components/ChartBullet/utils/chart-bullet-data.ts
Comment thread packages/patternfly-4/react-charts/src/components/ChartBullet/utils/chart-bullet-theme.ts
Comment thread ...ges/patternfly-4/react-charts/src/components/ChartDonutUtilization/ChartDonutUtilization.tsx
Comment thread packages/patternfly-4/react-charts/src/components/ChartUtils/chart-interactive-legend.ts
Comment thread packages/patternfly-4/react-charts/src/components/ChartUtils/chart-interactive-legend.ts
Comment thread packages/patternfly-4/react-charts/src/components/ChartUtils/chart-interactive-legend.ts
Comment thread packages/patternfly-4/react-charts/src/components/ChartUtils/chart-interactive-legend.ts
Comment thread packages/patternfly-4/react-charts/src/components/ChartUtils/chart-legend.ts Outdated
Comment thread packages/patternfly-4/react-charts/src/components/ChartUtils/chart-theme.ts
dlabrecq previously approved these changes Feb 12, 2020
View reviewed changes
tlabaj previously approved these changes Feb 12, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin dismissed stale reviews from tlabaj and dlabrecq via cfa98f4 February 14, 2020 14:16
tlabaj approved these changes Feb 14, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabrecq merged commit 7358db9 into patternfly:master Feb 14, 2020

patternfly-build commented Feb 14, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@5.2.29
  • @patternfly/react-docs@4.19.3

Thanks for your contribution! 🎉

evwilkin mentioned this pull request Feb 17, 2020
Closed
dlabrecq mentioned this pull request Mar 10, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL