FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(react-catalog-view-extension): fix linting errors by evwilkin · Pull Request #3714 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(react-catalog-view-extension): fix linting errors - #3714

Merged
redallen merged 5 commits into
patternfly:masterfrom
evwilkin:chore/lint-react-catalog-view-extension
Feb 12, 2020
ConversationCommits (5)ChecksFiles changed
Merged

chore(react-catalog-view-extension): fix linting errors#3714
redallen merged 5 commits into
patternfly:masterfrom
evwilkin:chore/lint-react-catalog-view-extension

Conversation

evwilkin commented Feb 10, 2020

Copy link
Copy Markdown
Member

What: Towards #3592 - resolves existing linting issues for react-catalog-view-extension

patternfly-build commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3714-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3714.surge.sh
A11y report: https://patternfly-react-pr-3714-coverage.surge.sh

codecov-io commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@8498226). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3714   +/-   ##
=========================================
  Coverage          ?   71.22%           
=========================================
  Files             ?      779           
  Lines             ?    10491           
  Branches          ?     2263           
=========================================
  Hits              ?     7472           
  Misses            ?     2592           
  Partials          ?      427
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 85.89% <ø> (?)
#patternfly4 60.13% <100%> (?)
Impacted Files Coverage Δ
...mponents/TopologyControlBar/TopologyControlBar.tsx 42.85% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8498226...2f3895a. Read the comment docs.

evwilkin force-pushed the chore/lint-react-catalog-view-extension branch from 9c3605a to ce4a342 Compare February 11, 2020 21:11
redallen suggested changes Feb 11, 2020
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just one concern

Comment thread packages/patternfly-4/react-catalog-view-extension/scripts/copyTS.js Outdated
ddonahue007 reviewed Feb 11, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Question on disabling check

Comment thread packages/patternfly-4/react-catalog-view-extension/node-sass-patternfly-importer.js Outdated
evwilkin force-pushed the chore/lint-react-catalog-view-extension branch from 5eee44f to 8498226 Compare February 11, 2020 22:06
evwilkin requested a review from redallen February 12, 2020 17:56
redallen merged commit d1483b8 into patternfly:master Feb 12, 2020
ddonahue007 approved these changes Feb 12, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

patternfly-build commented Feb 12, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.15
  • @patternfly/react-docs@4.18.18

Thanks for your contribution! 🎉

evwilkin mentioned this pull request Feb 17, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
dlabrecq dlabrecq approved these changes
redallen redallen approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL