FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(react-docs): resolved existing linting errors by evwilkin · Pull Request #3715 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(react-docs): resolved existing linting errors - #3715

Merged
evwilkin merged 3 commits into
patternfly:masterfrom
evwilkin:chore/lint-react-docs
Feb 12, 2020
ConversationCommits (3)ChecksFiles changed
Merged

chore(react-docs): resolved existing linting errors#3715
evwilkin merged 3 commits into
patternfly:masterfrom
evwilkin:chore/lint-react-docs

Conversation

evwilkin commented Feb 10, 2020

Copy link
Copy Markdown
Member

What: Towards #3592 - resolves linting errors for react-docs

patternfly-build commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3715-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3715.surge.sh
A11y report: https://patternfly-react-pr-3715-coverage.surge.sh

codecov-io commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3715 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3715   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         779      779           
  Lines       10491    10491           
  Branches     2263     2263           
=======================================
  Hits         7472     7472           
  Misses       2592     2592           
  Partials      427      427
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.13% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ca6ba...1c6c4a0. Read the comment docs.

dlabrecq previously approved these changes Feb 12, 2020
View reviewed changes
evwilkin force-pushed the chore/lint-react-docs branch from a9bb9b7 to 1c6c4a0 Compare February 12, 2020 20:36
ddonahue007 approved these changes Feb 12, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin merged commit a65afb4 into patternfly:master Feb 12, 2020
evwilkin deleted the chore/lint-react-docs branch February 12, 2020 21:10

patternfly-build commented Feb 12, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.17
  • @patternfly/react-charts@5.2.28
  • @patternfly/react-core@3.136.13
  • @patternfly/react-docs@4.18.20
  • @patternfly/react-inline-edit-extension@2.16.15
  • demo-app-ts@3.22.13
  • @patternfly/react-styled-system@3.7.33
  • @patternfly/react-styles@3.6.31
  • @patternfly/react-table@2.26.15
  • @patternfly/react-tokens@2.7.30
  • @patternfly/react-topology@2.13.16
  • @patternfly/react-virtualized-extension@1.3.111
  • @patternfly/react-icons@3.14.43

Thanks for your contribution! 🎉

evwilkin mentioned this pull request Feb 17, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL