FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Chore - lint react topology by evwilkin · Pull Request #3721 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Chore - lint react topology - #3721

Merged
ddonahue007 merged 4 commits into
patternfly:masterfrom
evwilkin:chore/lint-react-topology
Feb 11, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Chore - lint react topology#3721
ddonahue007 merged 4 commits into
patternfly:masterfrom
evwilkin:chore/lint-react-topology

Conversation

evwilkin commented Feb 11, 2020

Copy link
Copy Markdown
Member

What: Towards #3592 - resolves existing linter errors for react topology

patternfly-build commented Feb 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3721-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3721.surge.sh
A11y report: https://patternfly-react-pr-3721-coverage.surge.sh

codecov-io commented Feb 11, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3721 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3721   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files         779      779           
  Lines       10489    10489           
  Branches     2261     2261           
=======================================
  Hits         7470     7470           
  Misses       2592     2592           
  Partials      427      427
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff00d8...abfa3cc. Read the comment docs.

ddonahue007 approved these changes Feb 11, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ddonahue007 merged commit a759812 into patternfly:master Feb 11, 2020

patternfly-build commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.18.17
  • @patternfly/react-topology@2.13.14

Thanks for your contribution! 🎉

evwilkin mentioned this pull request Feb 17, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
redallen redallen approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL