FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(docs): updated table property descriptions by ddonahue007 · Pull Request #3745 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(docs): updated table property descriptions - #3745

Merged
redallen merged 2 commits into
patternfly:masterfrom
ddonahue007:table-desc_3190
Feb 13, 2020
ConversationCommits (2)ChecksFiles changed
Merged

fix(docs): updated table property descriptions#3745
redallen merged 2 commits into
patternfly:masterfrom
ddonahue007:table-desc_3190

Conversation

ddonahue007 commented Feb 13, 2020

Copy link
Copy Markdown
Member

Updated table property descriptions

patternfly-build commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3745-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3745.surge.sh
A11y report: https://patternfly-react-pr-3745-coverage.surge.sh

codecov-io commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3745 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3745   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files         779      779           
  Lines       10491    10491           
  Branches     2263     2263           
=======================================
  Hits         7472     7472           
  Misses       2592     2592           
  Partials      427      427
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.13% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 69.56% <ø> (ø) ⬆️
...nfly-4/react-table/src/components/Table/Header.tsx 85.71% <ø> (ø) ⬆️
...ernfly-4/react-table/src/components/Table/Body.tsx 78.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623222b...66f276f. Read the comment docs.

evwilkin previously approved these changes Feb 13, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - thanks for tackling this!

dlabrecq previously approved these changes Feb 13, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, unless @seanforyou23 can add to the descriptions?

seanforyou23 reviewed Feb 13, 2020
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Made a couple of small suggestions. Thanks for doing this!

Comment thread packages/patternfly-4/react-table/src/components/Table/Table.tsx Outdated
Comment thread packages/patternfly-4/react-table/src/components/Table/Table.tsx Outdated
ddonahue007 dismissed stale reviews from dlabrecq and evwilkin via 66f276f February 13, 2020 18:49
seanforyou23 approved these changes Feb 13, 2020
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

redallen merged commit 8b9374b into patternfly:master Feb 13, 2020

patternfly-build commented Feb 13, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.19.2
  • @patternfly/react-inline-edit-extension@2.16.20
  • @patternfly/react-table@2.26.20

Thanks for your contribution! 🎉

ddonahue007 deleted the table-desc_3190 branch February 13, 2020 20:48
seanforyou23 mentioned this pull request Feb 17, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin left review comments
jschuler Awaiting requested review from jschuler
+3 more reviewers
seanforyou23 seanforyou23 approved these changes
dlabrecq dlabrecq approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL