FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(table): revert IHeaderRow interface change by dlabrecq · Pull Request #3746 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(table): revert IHeaderRow interface change - #3746

Merged
ddonahue007 merged 1 commit into
patternfly:masterfrom
dlabrecq:3744-revert-interface-change
Feb 13, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix(table): revert IHeaderRow interface change#3746
ddonahue007 merged 1 commit into
patternfly:masterfrom
dlabrecq:3744-revert-interface-change

Conversation

dlabrecq commented Feb 13, 2020

Copy link
Copy Markdown
Member

It appears we changed an interface when introducing linting to the react-table package. This is exported, so reverting the breaking change.

fixes #3744

patternfly-build commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3746-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3746.surge.sh
A11y report: https://patternfly-react-pr-3746-coverage.surge.sh

ddonahue007 approved these changes Feb 13, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin approved these changes Feb 13, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - thanks Dan!

codecov-io commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3746 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3746   +/-   ##
=======================================
  Coverage   71.23%   71.23%           
=======================================
  Files         779      779           
  Lines       10492    10492           
  Branches     2264     2264           
=======================================
  Hits         7474     7474           
  Misses       2592     2592           
  Partials      426      426
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.15% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 69.56% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa650a3...93f6d80. Read the comment docs.

ddonahue007 merged commit 5230f98 into patternfly:master Feb 13, 2020
dlabrecq deleted the 3744-revert-interface-change branch October 29, 2021 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
redallen Awaiting requested review from redallen
+1 more reviewer
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table IHeaderRow interface changed type

5 participants

Back | FazBrowse Home | New Git URL