FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(master): merge v4 by redallen · Pull Request #4255 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(master): merge v4 - #4255

Merged
redallen merged 211 commits into
patternfly:masterfrom
redallen:feat/2020.06-merge
May 15, 2020
ConversationCommits (211)ChecksFiles changed
Merged

feat(master): merge v4#4255
redallen merged 211 commits into
patternfly:masterfrom
redallen:feat/2020.06-merge

Conversation

redallen commented May 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: For RC1

Additional issues: The breaking change lint is safe to ignore. We just need to make sure to omit the * Breaking changes: Alert when squash + merging in Github.

Notable conflicts: Select group, master detail demo

redallen and others added 30 commits March 3, 2020 15:53
chore(packages): publish to prerelease-v4
96570be
chore(release): releasing packages [ci skip]
835da40 
 - @patternfly/react-catalog-view-extension@4.0.1
 - @patternfly/react-charts@5.3.8
 - @patternfly/react-core@4.0.1
 - @patternfly/react-docs@4.20.25
 - @patternfly/react-inline-edit-extension@4.0.1
 - @patternfly/react-styled-system@4.0.1
 - @patternfly/react-styles@4.0.1
 - @patternfly/react-table@4.0.1
 - @patternfly/react-tokens@4.0.1
 - @patternfly/react-topology@4.0.1
 - @patternfly/react-virtualized-extension@4.0.1
make sure all packages publish to prerelease channel
5409049
chore(release): releasing packages [ci skip]
361669b 
 - @patternfly/react-core@4.0.2
 - @patternfly/react-docs@4.20.26
 - @patternfly/react-icons@3.15.6
 - @patternfly/react-inline-edit-extension@4.0.2
 - @patternfly/react-table@4.0.2
 - @patternfly/react-topology@4.0.2
 - @patternfly/react-virtualized-extension@4.0.2
add newline (patternfly#3868)
022b258
bump core
48a649b
chore(release): releasing packages [ci skip]
72f32ab 
 - @patternfly/react-catalog-view-extension@4.0.2
 - @patternfly/react-charts@5.3.9
 - @patternfly/react-core@4.0.3
 - @patternfly/react-docs@4.20.27
 - @patternfly/react-icons@3.15.7
 - @patternfly/react-inline-edit-extension@4.0.3
 - @patternfly/react-styled-system@4.0.2
 - @patternfly/react-styles@4.0.2
 - @patternfly/react-table@4.0.3
 - @patternfly/react-tokens@4.0.2
 - @patternfly/react-topology@4.0.3
 - @patternfly/react-virtualized-extension@4.0.3
chore(v4): bump other packages to versions that don't conflict with m…
6f53f68 
…aster
chore(release): releasing packages [ci skip]
ae774a2 
 - @patternfly/react-charts@6.0.1
 - @patternfly/react-codemods@2.0.1
 - @patternfly/react-docs@5.0.1
 - @patternfly/react-icons@4.0.1
 - @patternfly/react-integration@4.0.1
build(v4): fix build on v4 (patternfly#3915)
09ba95c 
* fix hoist-non-react-statics types

* also verify @patternfly package versions

* run verify script with --fix

* fix hoist-non-react-statics declaration

* fix linting errors

* fix drawer panel style

* update snapshots
chore(release): releasing packages [ci skip]
67d352a 
 - @patternfly/react-catalog-view-extension@4.0.3
 - @patternfly/react-charts@6.0.2
 - @patternfly/react-codemods@2.0.2
 - @patternfly/react-core@4.0.4
 - @patternfly/react-docs@5.0.2
 - @patternfly/react-icons@4.0.2
 - @patternfly/react-inline-edit-extension@4.0.4
 - demo-app-ts@3.25.10
 - @patternfly/react-integration@4.0.2
 - @patternfly/react-styled-system@4.0.3
 - @patternfly/react-table@4.0.4
 - @patternfly/react-topology@4.0.4
 - @patternfly/react-virtualized-extension@4.0.4
chore(v4): merge master (patternfly#3921)
3f6da3c 
* fix(ouia): don't omit ouiaContext (patternfly#3872)

* feat(Modal): add description property (patternfly#3821)

* feat(Modal): add description property, update id location when desc exists

* fix(Modal): lint error

* feat(Modal): add description to Modal

* feat(Modal): add description example to integration and cypress

* feat(Modal): update docs

* feat(DataList): add compact data list (patternfly#3807)

* feat(DataList): add compact flag

* feat(DataList): update tests, snapshots

* feat(DataList): add compact demo to integration

* feat(DataList): move integration demo back to integration

* docs(DataList): update aria label on example

* bump react-docs version (patternfly#3879)

* fix(wizard): use patternfly-styles to set the no padding modifier (patternfly#3871)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(react): bump to current tagged version in git (patternfly#3881)

* bump to current tagged version

* bump other problematic packages

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.22
 - @patternfly/react-charts@5.3.10
 - @patternfly/react-core@3.143.0
 - @patternfly/react-docs@4.20.28
 - @patternfly/react-icons@3.15.8
 - @patternfly/react-inline-edit-extension@2.17.22
 - demo-app-ts@3.26.0
 - @patternfly/react-integration@3.26.0
 - @patternfly/react-table@2.28.3
 - @patternfly/react-topology@2.14.22
 - @patternfly/react-virtualized-extension@1.4.23

* feat(ChipGroup): Added a tooltip to the Chipgroup label (patternfly#3826)

* feat(ChipGroup): Added a tooltip to the Chipgroup label

patternfly#3490

* fix linting errors

* add tabindex

* fix tabindex

* remove redundant code

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.23
 - @patternfly/react-core@3.144.0
 - @patternfly/react-docs@4.20.29
 - @patternfly/react-inline-edit-extension@2.17.23
 - demo-app-ts@3.27.0
 - @patternfly/react-integration@3.27.0
 - @patternfly/react-table@2.28.4
 - @patternfly/react-topology@2.14.23
 - @patternfly/react-virtualized-extension@1.4.24

* chore(react-core): remove exenv and lodash (patternfly#3882)

* chore(react-core): remove exenv and lodash

* remove accidental focus-trap change

* fix lint

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.24
 - @patternfly/react-codemods@1.1.5
 - @patternfly/react-core@3.144.1
 - @patternfly/react-docs@4.20.30
 - @patternfly/react-icons@3.15.9
 - @patternfly/react-inline-edit-extension@2.17.24
 - demo-app-ts@3.27.1
 - @patternfly/react-table@2.28.5
 - @patternfly/react-topology@2.14.24
 - @patternfly/react-virtualized-extension@1.4.25

* feat(Select): add inline filtering to checkbox select (patternfly#3843)

* feat(Select): add inline filtering

* feat(Select): add unit test

* feat(Select): add filtering select demo to integration

* feat(Select): add clear button, fix lint, update wider snapshots

* fix(integration): fix lint

* fix(docs): add missing import

* feat(Select): update integration tests with clear button changes

* feat(Select): move integration demos back to integration

* feat(Select): remove typeahead restriction on clear button

* docs(Select): update docs example

* PF4: Drawer updates for Master/Detail Support (patternfly#3884)

* feat(Drawer): Updated Drawer to support Master/Detail

patternfly#3609

* rebase

* update file that was not saved

* Update snapshots

* fix linting errors

* fix linting errors

* fix spacing issue

* updates from review comments

* updates from review comments

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.25
 - @patternfly/react-charts@5.3.11
 - @patternfly/react-core@3.145.0
 - @patternfly/react-docs@4.20.31
 - @patternfly/react-icons@3.15.10
 - @patternfly/react-inline-edit-extension@2.17.25
 - demo-app-ts@3.28.0
 - @patternfly/react-integration@3.28.0
 - @patternfly/react-styled-system@3.8.9
 - @patternfly/react-styles@3.7.7
 - @patternfly/react-table@2.28.6
 - @patternfly/react-tokens@2.8.7
 - @patternfly/react-topology@2.14.25
 - @patternfly/react-virtualized-extension@1.4.26

* fix (datatoolbar):  Added support for key with categoryName. (patternfly#3880)

* Issue3552 - added support for key with categoryName.

* Update to fix memory leak with datatoolbar filter.

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.26
 - @patternfly/react-core@3.145.1
 - @patternfly/react-docs@4.20.32
 - @patternfly/react-inline-edit-extension@2.17.26
 - demo-app-ts@3.28.1
 - @patternfly/react-table@2.28.7
 - @patternfly/react-topology@2.14.26
 - @patternfly/react-virtualized-extension@1.4.27

* feat(FileUpload) Add new beta File Upload component (patternfly#3865)

* feat(FileUpload) Add new beta File Upload component

* Bump patternfly versions to 2.68.3

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.27
 - @patternfly/react-charts@5.3.12
 - @patternfly/react-core@3.145.2
 - @patternfly/react-docs@4.20.33
 - @patternfly/react-icons@3.15.11
 - @patternfly/react-inline-edit-extension@2.17.27
 - demo-app-ts@3.28.2
 - @patternfly/react-styled-system@3.8.10
 - @patternfly/react-styles@3.7.8
 - @patternfly/react-table@2.28.8
 - @patternfly/react-tokens@2.8.8
 - @patternfly/react-topology@2.14.27
 - @patternfly/react-virtualized-extension@1.4.28

* destructure bubbleEvent from props to avoid it passing to button el (patternfly#3894)

* destructure bubbleEvent from props to avoid it passing to button el

* updated snapshots

* updated Table snapshot

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.28
 - @patternfly/react-core@3.145.3
 - @patternfly/react-docs@4.20.34
 - @patternfly/react-inline-edit-extension@2.17.28
 - demo-app-ts@3.28.3
 - @patternfly/react-table@2.28.9
 - @patternfly/react-topology@2.14.28
 - @patternfly/react-virtualized-extension@1.4.29

* feat(Modal): move description to separate component (patternfly#3897)

* feat(Modal): move description to separate component

* feat(Modal): fix property descriptions

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.29
 - @patternfly/react-core@3.146.0
 - @patternfly/react-docs@4.20.35
 - @patternfly/react-inline-edit-extension@2.17.29
 - demo-app-ts@3.28.4
 - @patternfly/react-table@2.28.10
 - @patternfly/react-topology@2.14.29
 - @patternfly/react-virtualized-extension@1.4.30

* chore(Realease Notes): Updated release notes for 2020.03 release (patternfly#3892)

* chore(Realease Notes): Updated release notes for 2020.03 release

patternfly#3891

* updates from comments

* update versions

* update based on comments

* update based on comments

* Update release notes

Fixed react-topology NPM link and Modal bullet points link text

Co-authored-by: Titani <tlabaj@redaht.com>
Co-authored-by: Evan <evan.wilkinson@redhat.com>

* fix(nothing): bumping to release 2020.03 release notes (patternfly#3908)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.30
 - @patternfly/react-core@3.146.1
 - @patternfly/react-docs@4.20.36
 - @patternfly/react-inline-edit-extension@2.17.30
 - demo-app-ts@3.28.5
 - @patternfly/react-table@2.28.11
 - @patternfly/react-topology@2.14.30
 - @patternfly/react-virtualized-extension@1.4.31

* blank update to force deploy (patternfly#3910)

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.31
 - @patternfly/react-core@3.146.2
 - @patternfly/react-docs@4.20.37
 - @patternfly/react-inline-edit-extension@2.17.31
 - demo-app-ts@3.28.6
 - @patternfly/react-integration@3.28.1
 - @patternfly/react-table@2.28.12
 - @patternfly/react-topology@2.14.31
 - @patternfly/react-virtualized-extension@1.4.32

* fix(dropdown): clean console errors in Dropdown.test.tsx (patternfly#3861)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* fix(aboutmodal): set a customize aria-label to the close button (patternfly#3877)

* fix(aboutmodal): set a customize aria-label to the close button

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* Quick sentence-case fix

Co-authored-by: Eugenia <32821331+jenny-s51@users.noreply.github.com>

* chore(repo): remove unused packages (patternfly#3916)

* remove unused packages

* fix hoist-non-react-statics type

* remove react-styled-system from react-docs

* fix lint

* don't deploy PRs from v4 branch

* enable chrome web security for failing cypress test

* fix external button link

* fix lint

Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Dan Labrecque <dlabrecq@redhat.com>
Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Titani <tlabaj@redaht.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Donald Labaj <donald.labaj@gmail.com>
Co-authored-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Co-authored-by: Evan <evan.wilkinson@redhat.com>
Co-authored-by: boaz0 <boaz.shuster.github@gmail.com>
Co-authored-by: Eugenia <32821331+jenny-s51@users.noreply.github.com>
chore(release): releasing packages [ci skip]
354f1de 
 - @patternfly/react-catalog-view-extension@4.0.4
 - @patternfly/react-core@4.0.5
 - @patternfly/react-docs@5.0.3
 - @patternfly/react-icons@4.0.3
 - @patternfly/react-inline-edit-extension@4.0.5
 - demo-app-ts@4.0.1
 - @patternfly/react-integration@4.0.3
 - @patternfly/react-table@4.0.5
 - @patternfly/react-topology@4.0.5
 - @patternfly/react-virtualized-extension@4.0.5
perf(react-styles): remove emotion, fix types (patternfly#3886)
2d762a3 
* fix(ouia): don't omit ouiaContext (patternfly#3872)

* feat(Modal): add description property (patternfly#3821)

* feat(Modal): add description property, update id location when desc exists

* fix(Modal): lint error

* feat(Modal): add description to Modal

* feat(Modal): add description example to integration and cypress

* feat(Modal): update docs

* feat(DataList): add compact data list (patternfly#3807)

* feat(DataList): add compact flag

* feat(DataList): update tests, snapshots

* feat(DataList): add compact demo to integration

* feat(DataList): move integration demo back to integration

* docs(DataList): update aria label on example

* bump react-docs version (patternfly#3879)

* fix(wizard): use patternfly-styles to set the no padding modifier (patternfly#3871)

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

* chore(react): bump to current tagged version in git (patternfly#3881)

* bump to current tagged version

* bump other problematic packages

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.22
 - @patternfly/react-charts@5.3.10
 - @patternfly/react-core@3.143.0
 - @patternfly/react-docs@4.20.28
 - @patternfly/react-icons@3.15.8
 - @patternfly/react-inline-edit-extension@2.17.22
 - demo-app-ts@3.26.0
 - @patternfly/react-integration@3.26.0
 - @patternfly/react-table@2.28.3
 - @patternfly/react-topology@2.14.22
 - @patternfly/react-virtualized-extension@1.4.23

* remove emotion, fix types

* fix some tests

* fix tests

* feat(ChipGroup): Added a tooltip to the Chipgroup label (patternfly#3826)

* feat(ChipGroup): Added a tooltip to the Chipgroup label

patternfly#3490

* fix linting errors

* add tabindex

* fix tabindex

* remove redundant code

Co-authored-by: Titani <tlabaj@redaht.com>

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.23
 - @patternfly/react-core@3.144.0
 - @patternfly/react-docs@4.20.29
 - @patternfly/react-inline-edit-extension@2.17.23
 - demo-app-ts@3.27.0
 - @patternfly/react-integration@3.27.0
 - @patternfly/react-table@2.28.4
 - @patternfly/react-topology@2.14.23
 - @patternfly/react-virtualized-extension@1.4.24

* add hoist-non-react-statics types

* fix v4 package versions

* chore(react-core): remove exenv and lodash (patternfly#3882)

* chore(react-core): remove exenv and lodash

* remove accidental focus-trap change

* fix lint

* fix lint

* chore(release): releasing packages [ci skip]

 - @patternfly/react-catalog-view-extension@1.4.24
 - @patternfly/react-codemods@1.1.5
 - @patternfly/react-core@3.144.1
 - @patternfly/react-docs@4.20.30
 - @patternfly/react-icons@3.15.9
 - @patternfly/react-inline-edit-extension@2.17.24
 - demo-app-ts@3.27.1
 - @patternfly/react-table@2.28.5
 - @patternfly/react-topology@2.14.24
 - @patternfly/react-virtualized-extension@1.4.25

* ts fixes

* fix lint

* fix backgroundImage on chrome

* fix filter

* fix merge conflict

* fix lint+snaps

* fix invalid data toolbar classes

* linting

* remove console logs

* add aria-label to wizard toggle

* update snapshots

* update snapshots

* address joachim's feedback

* remove accidental auto-import

* update snapshots

Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Dan Labrecque <dlabrecq@redhat.com>
Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com>
Co-authored-by: patternfly-build <patternfly-build@redhat.com>
Co-authored-by: Titani <tlabaj@redaht.com>
chore(release): releasing packages [ci skip]
83924aa 
 - @patternfly/react-catalog-view-extension@4.0.5
 - @patternfly/react-charts@6.0.3
 - @patternfly/react-core@4.0.6
 - @patternfly/react-docs@5.0.4
 - @patternfly/react-inline-edit-extension@4.0.6
 - demo-app-ts@4.0.2
 - @patternfly/react-integration@4.0.4
 - @patternfly/react-styles@4.0.3
 - @patternfly/react-table@4.0.6
 - @patternfly/react-topology@4.0.6
 - @patternfly/react-virtualized-extension@4.0.6
perf(ouia): make ouia functional, add namespace (patternfly#3927)
05bee77 
* helper implementation

* update ouia components

* rename data-ouia-id to data-ouia-component-id

* fix lint
chore(release): releasing packages [ci skip]
c979ec6 
 - @patternfly/react-catalog-view-extension@4.0.6
 - @patternfly/react-charts@6.0.4
 - @patternfly/react-core@4.0.7
 - @patternfly/react-docs@5.0.5
 - @patternfly/react-inline-edit-extension@4.0.7
 - demo-app-ts@4.0.3
 - @patternfly/react-integration@4.0.5
 - @patternfly/react-styles@4.0.4
 - @patternfly/react-table@4.0.7
 - @patternfly/react-topology@4.0.7
 - @patternfly/react-virtualized-extension@4.0.7
Empty state width (patternfly#3933)
c104df9 
* refactor(Empty State): Change the default width to full instead of large

patternfly#3221

* add dchanges for issue patternfly#3873

* fix demo app

Co-authored-by: Titani <tlabaj@redaht.com>
chore(release): releasing packages [ci skip]
db99885 
 - @patternfly/react-catalog-view-extension@4.0.7
 - @patternfly/react-core@4.0.8
 - @patternfly/react-docs@5.0.6
 - @patternfly/react-inline-edit-extension@4.0.8
 - demo-app-ts@4.0.4
 - @patternfly/react-integration@4.0.6
 - @patternfly/react-table@4.0.8
 - @patternfly/react-topology@4.0.8
 - @patternfly/react-virtualized-extension@4.0.8
fix(react-integration): no implicit any (patternfly#3928)
611ae97 
* fixed implicit any errors through DataToolbarDemo

* resolved errors through FormSelectDemo

* resolved all noImplicitAny within react-integration

* reverted null value

* reverted undefined values

* updated SelectDemo arrays

* strict function types on contextselector and datatoolbar

* Revert "strict function types on contextselector and datatoolbar"

This reverts commit 5ff0abf.

* removed any where possible

* PR feedback fixes - added back in untyped events

* PR feedback - removed editing prevState in DataToolbar

* updated DataToolbar core example

* remove type from core example
chore(release): releasing packages [ci skip]
ab06daf 
 - @patternfly/react-catalog-view-extension@4.0.8
 - @patternfly/react-core@4.0.9
 - @patternfly/react-docs@5.0.7
 - @patternfly/react-inline-edit-extension@4.0.9
 - demo-app-ts@4.0.5
 - @patternfly/react-integration@4.0.7
 - @patternfly/react-table@4.0.9
 - @patternfly/react-topology@4.0.9
 - @patternfly/react-virtualized-extension@4.0.9
refactor(ApplicationLauncher): Removed the deprecated prop dropdownIt…
d156eb4 
…ems (patternfly#3929)

* refactor(ApplicationLauncher): Removed the deprecated prop dropdownItems

patternfly#2582

* rebase

Co-authored-by: Titani <tlabaj@redaht.com>
chore(release): releasing packages [ci skip]
f26fd0c 
 - @patternfly/react-catalog-view-extension@4.0.9
 - @patternfly/react-core@4.0.10
 - @patternfly/react-docs@5.0.8
 - @patternfly/react-inline-edit-extension@4.0.10
 - demo-app-ts@4.0.6
 - @patternfly/react-integration@4.0.8
 - @patternfly/react-table@4.0.10
 - @patternfly/react-topology@4.0.10
 - @patternfly/react-virtualized-extension@4.0.10
fix(table): update types in table (patternfly#3296)
42f6060 
update/align onSelect event type from React.MouseEvent and React.ChangeEvent<HTMLInputElement> to React.FormEvent<HTMLInputElement>
clear todo and tslint error in selectable transform
types for ICustomCell and ISelectTransform
clear noImplicitAny errors for Table
chore(release): releasing packages [ci skip]
88a37c3 
 - @patternfly/react-docs@5.0.9
 - @patternfly/react-inline-edit-extension@4.0.11
 - demo-app-ts@4.0.7
 - @patternfly/react-integration@4.0.9
 - @patternfly/react-table@4.0.11
Aria property name updates (patternfly#3924)
2ef0b12 
* fix(aria-props): align aria related property names patternfly#1529

* [cleanup] sentence case for aria-prop docs
feat(Alert): change default alert variant to default (patternfly#3903)
4a88fc0 
* feat(Alert): change default alert variant to default

* feat(Alert): rebase conflicts, update demo app

* feat(Alert): update snapshots
feat(Page): make mainContainerId required (patternfly#3904)
ee54a45
chore(release): releasing packages [ci skip]
f479e76 
 - @patternfly/react-catalog-view-extension@4.0.10
 - @patternfly/react-core@4.1.0
 - @patternfly/react-docs@5.0.10
 - @patternfly/react-inline-edit-extension@4.0.12
 - demo-app-ts@4.1.0
 - @patternfly/react-integration@4.1.0
 - @patternfly/react-table@4.0.12
 - @patternfly/react-topology@4.0.11
 - @patternfly/react-virtualized-extension@4.0.11
feat(Charts): Bump Victory packages (3973) (patternfly#3974)
23bd48e
patternfly-build and others added 3 commits May 14, 2020 18:47
chore(release): releasing packages [ci skip]
0a91609 
 - @patternfly/react-catalog-view-extension@4.2.37
 - @patternfly/react-core@4.14.0
 - @patternfly/react-docs@5.2.43
 - @patternfly/react-inline-edit-extension@4.3.38
 - demo-app-ts@4.10.0
 - @patternfly/react-integration@4.10.0
 - @patternfly/react-table@4.3.38
 - @patternfly/react-topology@4.2.37
 - @patternfly/react-virtualized-extension@4.2.38
Merge remote-tracking branch 'upstream/v4' into feat/2020.06-merge
d768fab
fix tests
f6b8504
redallen changed the title Feat/2020.06 merge feat(master): merge v4 May 14, 2020

patternfly-build commented May 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF4 preview: https://patternfly-react-pr-4255.surge.sh
A11y report: https://patternfly-react-pr-4255-coverage.surge.sh

redallen and others added 4 commits May 14, 2020 16:43
fix md lint
8e586ba
update snapshots
04aca3c
update card demo header tools (patternfly#4254)
bb0f623
chore(release): releasing packages [ci skip]
87e685b 
 - @patternfly/react-catalog-view-extension@4.2.38
 - @patternfly/react-core@4.14.1
 - @patternfly/react-docs@5.2.44
 - @patternfly/react-inline-edit-extension@4.3.39
 - demo-app-ts@4.10.1
 - @patternfly/react-table@4.3.39
 - @patternfly/react-topology@4.2.38
 - @patternfly/react-virtualized-extension@4.2.39
dlabrecq previously approved these changes May 14, 2020
View reviewed changes
ddonahue007 previously approved these changes May 14, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen dismissed stale reviews from ddonahue007 and dlabrecq via 35204c3 May 15, 2020 13:33
jschuler reviewed May 15, 2020
View reviewed changes
Comment thread ADVANCED-USAGE-README.md

Use ESM module imports to enable tree shaking with no additional setup required.
```JS
import { TimesIcon } from '@patternfly/react-icons';

jschuler May 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

is this ok, i thought we were directly importing from the file not the barrel

redallen May 15, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Consumers are free to use this syntax. This was from #4086

redallen mentioned this pull request May 15, 2020
Closed
ddonahue007 previously approved these changes May 15, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen requested review from ddonahue007 and tlabaj May 15, 2020 15:13
ddonahue007 approved these changes May 15, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler approved these changes May 15, 2020
View reviewed changes

jschuler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's goooooo

redallen merged commit 567c0b8 into patternfly:master May 15, 2020
michpetrov mentioned this pull request May 19, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabrecq Awaiting requested review from dlabrecq
tlabaj Awaiting requested review from tlabaj
2 more reviewers
jschuler jschuler approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL