FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adds content to select component examples. by edonehoo · Pull Request #8399 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Adds content to select component examples. - #8399

Merged
nicolethoen merged 1 commit into
patternfly:v5from
edonehoo:iss2990-select
Mar 9, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Adds content to select component examples.#8399
nicolethoen merged 1 commit into
patternfly:v5from
edonehoo:iss2990-select

Conversation

edonehoo commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Makes progress on patternfly/patternfly-org#2990

patternfly-build commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://patternfly-react-pr-8399.surge.sh

A11y report: https://patternfly-react-pr-8399-a11y.surge.sh

edonehoo commented Nov 30, 2022

Copy link
Copy Markdown
Contributor Author

I wouldn't be shocked if there's a typo causing this issue -- I'll look into it

jenny-s51 reviewed Dec 1, 2022
View reviewed changes

jenny-s51 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@edonehoo importing SelectVariant into the examples below should hopefully fix your build issue!

Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
edonehoo self-assigned this Dec 1, 2022
thatblindgeye requested changes Dec 13, 2022
View reviewed changes

thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is looking really good! Some of my comments below include possibly changing the order of examples, so let me know what you think!

Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated

edonehoo commented Dec 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks, @thatblindgeye! Any ideas re: the build failing? Also @nicolethoen @evwilkin

EDIT: nvm just saw Eric's comment!

nicolethoen reviewed Jan 6, 2023
View reviewed changes
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
thatblindgeye requested changes Jan 6, 2023
View reviewed changes

thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is looking great! In addition to comments above, just had one more below

Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated

edonehoo commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

Does it make sense to change "custom filtering" to "typeahead with custom filtering"? I know the focus of the example is on the filtering part, but it's also a typeahead example, so I added "typeahead" to mirror the other examples. Can't decide if that makes the example more or less unclear.

In general - are any titles too wordy? How does the ordering look now?

thatblindgeye reviewed Jan 10, 2023
View reviewed changes

thatblindgeye left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does it make sense to change "custom filtering" to "typeahead with custom filtering"? I know the focus of the example is on the filtering part, but it's also a typeahead example, so I added "typeahead" to mirror the other examples. Can't decide if that makes the example more or less unclear.

In general - are any titles too wordy? How does the ordering look now?

Considering the other examples in that section have "Typeahead..." before it, I think it would make sense to add that to the custom filtering example.

Since we can't currently have subsections under that "Examples" heading without breaking the build, I think the titles as they are fine. Some possible alternatives are below, but they aren't blockers to me and would be interested in what others think.

Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
Comment thread packages/react-core/src/components/Select/examples/Select.md Outdated
nicolethoen changed the base branch from main to v5 February 16, 2023 14:25
nicolethoen merged commit b043918 into patternfly:v5 Mar 9, 2023

patternfly-build commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.30
  • @patternfly/react-core@5.0.0-alpha.30
  • @patternfly/react-docs@6.0.0-alpha.33
  • demo-app-ts@5.0.0-alpha.13
  • @patternfly/react-table@5.0.0-alpha.30

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nicolethoen nicolethoen approved these changes
thatblindgeye thatblindgeye approved these changes
jenny-s51 Awaiting requested review from jenny-s51

Assignees

edonehoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL