FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Remove vitest since it's not compatible with webpack by dlabaj · Pull Request #266 · patternfly/patternfly-react-seed · GitHub

/ patternfly-react-seed Public

fix: Remove vitest since it's not compatible with webpack - #266

Merged
dlabaj merged 2 commits into
compass_themefrom
compass_theme_rm_vitest
Feb 4, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix: Remove vitest since it's not compatible with webpack#266
dlabaj merged 2 commits into
compass_themefrom
compass_theme_rm_vitest

Conversation

dlabaj commented Feb 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Vitest can only be used with Vite. Since this product is being built using webpack at the moment, we can not use vitest. We can create a new vite branch to allow users who want to use vite to checkout that branch instead.

Closes issue: #264

dlabaj requested review from evwilkin and kmcfaul February 1, 2026 14:52
dlabaj linked an issue Feb 1, 2026 that may be closed by this pull request
Build is failing due to new vite configuration file #264
Closed

evwilkin commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@dlabaj it looks like this has 51 files changed, more than just the description would suggest - thinking it shouldn't be targeting the main branch? Also a small lint error about import order by alphabetical name.

dlabaj changed the base branch from main to compass_theme February 2, 2026 18:33

dlabaj commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@evwilkin Fixed the branch it was going into, thanks for catching that. It should be going into the compass_theme branch.

dlabaj requested a review from jpuzz0 February 2, 2026 18:34
jpuzz0 reviewed Feb 3, 2026
View reviewed changes
Comment thread package.json
"jsdom": "^25.0.1",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"jest-fixed-jsdom": "^0.0.9",

jpuzz0 Feb 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this package being used?

dlabaj Feb 4, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes by jest in setup. It's used when running tests.

jpuzz0 Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If it were being used it would be specified as the testEnvironment in jest.config.cjs, right? If this is wrong, please explain.

Instead I see testEnvironment: 'jest-environment-jsdom',, so I'm still not sure how jest-fixed-jsdom is used, as its not imported or specified anywhere else I can see.

jpuzz0 approved these changes Feb 3, 2026
View reviewed changes

jpuzz0 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Outside of the 1 lint issue and 1 minor comment, LGTM

dlabaj merged commit 3810e14 into compass_theme Feb 4, 2026
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jpuzz0 jpuzz0 approved these changes
evwilkin Awaiting requested review from evwilkin
kmcfaul Awaiting requested review from kmcfaul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build is failing due to new vite configuration file

3 participants

Back | FazBrowse Home | New Git URL