FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(setup): correct python_requires to >=3.8 by masaru87 · Pull Request #32 · payjp/payjp-python · GitHub

fix(setup): correct python_requires to >=3.8 - #32

Open
masaru87 wants to merge 1 commit into
payjp:masterfrom
masaru87:fix-python-requires-3.8
Open

fix(setup): correct python_requires to >=3.8#32
masaru87 wants to merge 1 commit into
payjp:masterfrom
masaru87:fix-python-requires-3.8

Conversation

Copy link
Copy Markdown

setup.py declares python_requires=">=3.0", but everything else in the package targets Python 3.8+:

  • setup.py itself raises on older versions: if sys.version_info < (3, 8): raise DeprecationWarning("Python versions below 3.8 are no longer supported by PAY.JP...")
  • README: "Python 3.8 or later"
  • pyproject.toml: [tool.ruff] target-version = "py38"
  • and the commit that added the 3.8 guard ("enforce Python 3.8 or higher in setup")

Because python_requires is published as >=3.0, pip does not gate the Python version correctly: on Python 3.0–3.7 pip still considers the latest release installable, so users hit the runtime guard (or 3.8+ code) instead of pip's normal "requires a different Python" message. This updates python_requires to >=3.8 to match the stated support policy.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL