pmseries_import: use a datetime UTC interface from python3.6 - #2203
Merged
natoscott merged 2 commits intoMay 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Resolves an issue Ken reported running tests in the QA farm, which is due to use of an interface from more-recent-python: python/cpython#91973
The 'text' parameter to subprocess.run() was added in python 3.6 as a more convenient / clear interface - switch to the mechanism available from the release we support. https://docs.python.org/3/library/subprocess.html#subprocess.run
Copy link
Copy Markdown
Member
|
@natoscott LGTM. I've installed your latest version of archive-import.py and run qa/1807 successfully on each of the following:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an issue Ken reported running tests in the QA farm, which is due to use of an interface from more-recent-python: python/cpython#91973