FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feature: healthcheck ready wait for all data sources load by charlottebrady · Pull Request #803 · permitio/opal · GitHub

/ opal Public

feature: healthcheck ready wait for all data sources load - #803

Draft
charlottebrady wants to merge 4 commits into
permitio:masterfrom
charlottebrady:feature/issue-801/ready-healthcheck-source-load
Draft

feature: healthcheck ready wait for all data sources load#803
charlottebrady wants to merge 4 commits into
permitio:masterfrom
charlottebrady:feature/issue-801/ready-healthcheck-source-load

Conversation

charlottebrady commented Jul 3, 2025
edited
Loading

Copy link
Copy Markdown

Fixes Issue

Closes #801

Changes proposed

This PR:
🌟 Adds a query to the /ready endpoint, defaults to false to maintain current behaviour.
🌟 Propagates the query through the system to the is_ready healthcheck method
🌟 If the query parameter = True, then we mark the system as 'ready' when the number of successful data transactions matches the total number of expected data transactions (defined from the opal data config sources)

  • One issue I can see with this is that the /healthy endpoint should check the system is 'ready' (as defined by the ready endpoint) with a little extra too. However, I have not touched the /healthy code here.
  • This should require a documentation update which I have not done yet.

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

netlify Bot commented Jul 3, 2025
edited
Loading

Copy link
Copy Markdown

Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 7374cbf
🔍 Latest deploy log https://app.netlify.com/projects/opal-docs/deploys/6866a9a02d5a050008e26811

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/ready healthcheck to be dependant on initial data sources load

1 participant


Back | FazBrowse Home | New Git URL