fix: removed inject decorator provided by dependency_injector - #24
Open
XyLearningProgramming wants to merge 1 commit into
Open
fix: removed inject decorator provided by dependency_injector#24XyLearningProgramming wants to merge 1 commit into
XyLearningProgramming wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your amazing project showing an example of ddd pattern.
I found that the @injector decorators are actually not in use. For usages like Annotated[Application, Depends(get_application)], it is FastAPI that solves dependencies by calling this func directly: source code here.
If you'd like to use dependency-injector directly with FastAPI, according to this doc, the dependent should be formalized with dependency_injector.Provide as Depends(Provide[ApplicationContainer.application]) or Depends(Provide["application"]).
This PR removed @injector decorators.