Fix the sample code of SQLModel - #157
Closed
linyuansup wants to merge 2 commits into
Closed
linyuansup wants to merge 2 commits into
linyuansup wants to merge 2 commits into
Conversation
…the definition of the vector column
Copy link
Copy Markdown
There was a problem hiding this comment.
🟡 Changes recommended
The README sample needs a Column import to avoid a NameError.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overviewUpdates SQLModel README examples for SQLAlchemy execution and Pylance-compatible vector declarations.
Changes:
- Uses conn.execute() within engine.begin().
- Defines the vector field with sa_column=Column(VECTOR(3)).
| File | Summary | Review note |
|---|---|---|
| README.md | Updates SQLModel usage examples. | Add the missing Column import. |
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
README.md
Copy link
Copy Markdown
Member
|
Hi @linyuansup, the code runs fine. See fastapi/sqlmodel#1657 and fastapi/sqlmodel#1345. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.