Fix: Escape key exits full screen on macOS desktop - #3119
Closed
devvaannsh wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Closing as the appropriate fix should come at a shell level |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing as the appropriate fix should come at a shell level
On macOS desktop, pressing Escape when nothing in the app was using it (for example after clicking the sidebar) made the app leave full screen. The unhandled key was reaching the native window, which treats Escape as exit full screen.
This change stops the unhandled Escape key from reaching the window. Escape still works as before in the editor, terminal and dialogs. Only affects the macOS desktop app.