FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Declare called methods in interfaces by cmb69 · Pull Request #25 · php/php-sdk-binary-tools · GitHub

  1. php
  2. php-sdk-binary-tools

Repository navigation

Declare called methods in interfaces #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmb69 wants to merge 1 commit into
base: master
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 0 Commits 1 Checks 0 Files changed
Open

Declare called methods in interfaces #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .php  (9) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 2 additions & 0 deletions lib/php/libsdk/SDK/Build/PGO/Interfaces/PHP.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ public function up() : void;
public function down(bool $force = false) : void;
public function getVersion(bool $short = false) : string;
public function getExeFilename() : string;
public function getRootDir() : string;
public function getExtRootDir() : string;
}
6 changes: 5 additions & 1 deletion lib/php/libsdk/SDK/Build/PGO/Interfaces/TrainingCase.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

interface TrainingCase
{
public function __construct(PGOConfig $conf, ?Server $srv_http, ?Server\DB $srv_db);
public function __construct(PGOConfig $conf, ?Server\HTTP $srv_http, ?Server\DB $srv_db);

/* Name of the training case, usually should be same as dirname and namespace. */
public function getName() : string;
Expand All @@ -24,4 +24,8 @@ public function run() : void;

/* Get training type, it's like "web", "cli", etc.*/
public function getType() : string;

public function getJobFilename() : string;

public function httpStatusOk(int $status) : bool;
}
4 changes: 2 additions & 2 deletions pgo/cases/drupal/TrainingCaseHandler.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -23,7 +23,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 8;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/joomla/TrainingCaseHandler.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/mediawiki/TrainingCaseHandler.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -23,7 +23,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $srv_db)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $srv_db)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/pgo01org/TrainingCaseHandler.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var ?Interfaces\Server\DB */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 12;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/symfony_demo/TrainingCaseHandler.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -23,7 +23,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $srv_db)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $srv_db)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/symfony_demo_pdo_mysql/TrainingCaseHandler.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var ?Interfaces\Server\DB */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $srv_db)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $srv_db)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/wordpress/TrainingCaseHandler.php
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var ?Interfaces\Server\DB */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
Back | FazBrowse Home | New Git URL