Fix, update and re-activate symfony_demo PGO training case - #27
Draft
cmb69 wants to merge 1 commit into
Draft
cmb69 wants to merge 1 commit into
cmb69 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This test case had been deactivated a couple of years ago[1], because it was broken[2]. We fix it by switching to the composer installation of the Symfony demo application, update to version 2.4.0 (which is the last version supporting PHP 8.1, but apparently also runs fine with PHP 8.4), and re-activate it. [1] <php@7893436> [2] <microsoft/php-sdk-binary-tools#73>
Copy link
Copy Markdown
Member
Author
|
Need to run this in production mode; adding an .env.local might be a suitable solution: APP_ENV=prod |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test case had been deactivated a couple of years ago[1], because it was broken[2]. We fix it by switching to the composer installation of the Symfony demo application, update to version 2.4.0 (which is the last version supporting PHP 8.1, but apparently also runs fine with PHP 8.4), and re-activate it.
[1] 7893436
[2] microsoft/php-sdk-binary-tools#73
Note that I run a full PGO build for the PHP-8.2 and the master branch only, and didn't notice any issues. This needs further testing; likely after some dependencies have been updated.