Commit 57ce245
authored
Reduce code bloat in arginfo by using specialised string releases (#20016)
* Reduce code bloat in arginfo by using specialised string releases
Comparing this patch to master (c7da728),
with a plain configure command without any options:
```
text data bss dec hex filename
20683738 1592400 137712 22413850 156021a sapi/cli/php
20688522 1592400 137712 22418634 15614ca sapi/cli/php_old
```
We see a minor reduction of 0.023% in code size.
* Also use true for the other initialization line
* Also use specialized code for consts1 parent 418c755 commit 57ce245
59 files changed
Lines changed: 3796 additions & 3796 deletions
File tree
- Zend
- build
- ext
- bcmath
- curl
- date
- dl_test
- dom
- ffi
- intl
- breakiterator
- calendar
- collator
- converter
- dateformat
- formatter
- listformatter
- locale
- normalizer
- rangeformatter
- spoofchecker
- timezone
- transliterator
- uchar
- libxml
- mysqli
- pdo_dblib
- pdo_firebird
- pdo_mysql
- pdo_odbc
- pdo_pgsql
- pdo_sqlite
- pdo
- phar
- random
- reflection
- snmp
- soap
- spl
- sqlite3
- standard
- tidy
- tokenizer
- uri
- xmlreader
- xsl
- zend_test
- zip
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2801,7 +2801,7 @@ private function getClassConstDeclaration(EvaluatedValue $value, array $allConst | |||
| 2801 | 2801 | ||
| 2802 | 2802 | $code = "\n" . $zvalCode; | |
| 2803 | 2803 | ||
| 2804 | - $code .= "\tzend_string *const_{$constName}_name = zend_string_init_interned(\"$constName\", sizeof(\"$constName\") - 1, 1);\n"; | ||
| 2804 | + $code .= "\tzend_string *const_{$constName}_name = zend_string_init_interned(\"$constName\", sizeof(\"$constName\") - 1, true);\n"; | ||
| 2805 | 2805 | $nameCode = "const_{$constName}_name"; | |
| 2806 | 2806 | ||
| 2807 | 2807 | if ($this->exposedDocComment) { | |
@@ -2855,7 +2855,7 @@ private function getClassConstDeclaration(EvaluatedValue $value, array $allConst | |||
| 2855 | 2855 | $code .= "#endif\n"; | |
| 2856 | 2856 | } | |
| 2857 | 2857 | ||
| 2858 | - $code .= "\tzend_string_release(const_{$constName}_name);\n"; | ||
| 2858 | + $code .= "\tzend_string_release_ex(const_{$constName}_name, true);\n"; | ||
| 2859 | 2859 | ||
| 2860 | 2860 | return $code; | |
| 2861 | 2861 | } | |
@@ -3058,13 +3058,13 @@ public static function getString( | |||
| 3058 | 3058 | // Generally strings will not be known | |
| 3059 | 3059 | $initFn = $interned ? 'zend_string_init_interned' : 'zend_string_init'; | |
| 3060 | 3060 | $result = [ | |
| 3061 | - "\tzend_string *$varName = $initFn(\"$content\", sizeof(\"$content\") - 1, 1);\n", | ||
| 3061 | + "\tzend_string *$varName = $initFn(\"$content\", sizeof(\"$content\") - 1, true);\n", | ||
| 3062 | 3062 | $varName, | |
| 3063 | - "\tzend_string_release($varName);\n" | ||
| 3063 | + "\tzend_string_release_ex($varName, true);\n" | ||
| 3064 | 3064 | ]; | |
| 3065 | 3065 | // For attribute values that are not freed | |
| 3066 | 3066 | if ($varName === '') { | |
| 3067 | - $result[0] = "$initFn(\"$content\", sizeof(\"$content\") - 1, 1);\n"; | ||
| 3067 | + $result[0] = "$initFn(\"$content\", sizeof(\"$content\") - 1, true);\n"; | ||
| 3068 | 3068 | } | |
| 3069 | 3069 | // If not set, use the current latest version | |
| 3070 | 3070 | $allVersions = ALL_PHP_VERSION_IDS; | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments