Reduce code bloat in arginfo by using specialised string releases - #20016
Merged
ndossche merged 3 commits intoOct 2, 2025
Merged
Reduce code bloat in arginfo by using specialised string releases#20016ndossche merged 3 commits into
ndossche merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comparing this patch to master (c7da728), with a plain configure command without any options: ``` text data bss dec hex filename 20683738 1592400 137712 22413850 156021a sapi/cli/php 20688522 1592400 137712 22418634 15614ca sapi/cli/php_old ``` We see a minor reduction of 0.023% in code size.
ndossche
marked this pull request as ready for review
September 30, 2025 16:03
ndossche
requested review from
Girgias,
TimWolla,
bukka,
kocsismate and
zeriyoshi
as code owners
September 30, 2025 16:03
ndossche
requested review from
SakiTakamachi,
adoy,
derickr,
devnexen and
kamil-tekiela
as code owners
September 30, 2025 16:03
Girgias
approved these changes
Sep 30, 2025
devnexen
approved these changes
Sep 30, 2025
kocsismate
approved these changes
Sep 30, 2025
TimWolla
removed their request for review
October 1, 2025 09:05
zeriyoshi
approved these changes
Oct 1, 2025
ndossche
requested review from
DanielEScherzer,
NattyNarwhal and
dstogov
as code owners
October 2, 2025 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing this patch to master (c7da728), with a plain configure command without any options:
We see a minor reduction of 0.023% in code size.