FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ext/curl: applied fixers to improve test robustness by NickSdot · Pull Request #23038 · php/php-src · GitHub

/ php-src Public

ext/curl: applied fixers to improve test robustness - #23038

Merged
LamentXU123 merged 1 commit into
php:masterfrom
NickSdot:test/hardening/ext-curl
Aug 12, 2026
ConversationCommits (1)ChecksFiles changed
Merged

ext/curl: applied fixers to improve test robustness#23038
LamentXU123 merged 1 commit into
php:masterfrom
NickSdot:test/hardening/ext-curl

Conversation

NickSdot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Asserts error class; extracted from: #22799

NickSdot marked this pull request as ready for review August 4, 2026 15:37
NickSdot requested a review from adoy as a code owner August 4, 2026 15:37

NickSdot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@LamentXU123 since you answered in the other PR with the same maintainer, they seem inactive (last commit last year)? Would you maybe want to look at this one? I can rebase.

LamentXU123 commented Aug 11, 2026

Copy link
Copy Markdown
Member

I am not responsible for the curl extension. Hmmm, maybe @Sjord can decide this?

I am fine with this change btw.

NickSdot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

I am not responsible for the curl extension. Hmmm, maybe @Sjord can decide this?

I literally checked CODEOWNERS before I commented this and only saw the one maintainer. Didn't mean to bypass anyone, sorry!

NickSdot force-pushed the test/hardening/ext-curl branch from 470ba1f to b14eab8 Compare August 11, 2026 20:08
Sjord mentioned this pull request Aug 11, 2026
Closed

Sjord commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Looks good to me.

As I said, #23183 also contains some of these changes.

NickSdot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

The failure is an unrelated flake, ref: #23217

LamentXU123 merged commit a1fdc0b into php:master Aug 12, 2026
33 of 34 checks passed

LamentXU123 commented Aug 12, 2026

Copy link
Copy Markdown
Member

Thank you!

NickSdot deleted the test/hardening/ext-curl branch August 12, 2026 11:17
NickSdot mentioned this pull request Aug 16, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

adoy Awaiting requested review from adoy adoy is a code owner

Assignees

No one assigned

Labels

Extension: curl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL