ext/standard: applied fixers to improve test robustness by NickSdot · Pull Request #23136 · php/php-src · GitHub

Asserts error class; extracted from: #22799

GitHub is lagging this, easier to review with: https://diffshub.com/php/php-src/pull/23136

@bukka following your comment yesterday I reviewed this one once again, and wanted to double check.

Out of 4,210 total lines, 13 (in 4 files) are affected by the same style-only thematic. Are you here okay with unifying those 13 lines with the rest or do you want me to make a manual follow up?
And while we are on it... Currently line endings are untouched; some said output always should be \n, others don't wanted them to be touched. Would you prefer to convert to \n or nah?

I would make a manual follow up to get these addressed.

Files affected by the style-only thematic:
ext/standard/tests/array/gh22678.phpt
ext/standard/tests/filters/gh20370.phpt
ext/standard/tests/strings/gh20906_1.phpt
ext/standard/tests/strings/setlocale_null_byte.phpt

There are loads of ZPP tests that should be removed, would make the diff smaller and reduce the test suite aswell.

This is a ZPP test and should be removed.

Ditto ZPP test

Diito

Ditto

ditto

Ditto

There are loads of ZPP tests that should be removed, would make the diff smaller and reduce the test suite aswell.

@Girgias that's done in #23413 -- when merged I will rebase and resolve here.

github-actions Bot added the Extension: standard label Aug 8, 2026

NickSdot marked this pull request as ready for review August 8, 2026 08:19

NickSdot requested a review from bukka as a code owner August 8, 2026 08:19

NickSdot mentioned this pull request Aug 16, 2026

Tests: Test exception type in error tests #22799

Draft

NickSdot force-pushed the test/hardening/ext-standard branch 3 times, most recently from 6176c2d to ebced5a Compare August 19, 2026 14:08

NickSdot added 3 commits August 22, 2026 01:10

ext/standard: applied fixers to improve test robustness

ed1ed9f

fix: kept sibling catch types

6072a9e

fix: removed extra line

f9206bf

NickSdot force-pushed the test/hardening/ext-standard branch from ebced5a to f9206bf Compare August 21, 2026 18:25

Girgias reviewed Aug 22, 2026

View reviewed changes

NickSdot mentioned this pull request Aug 22, 2026

ext/standard: Removes ZPP style tests #23413

Open

ext/standard: applied fixers to improve test robustness by NickSdot · Pull Request #23136 · php/php-src · GitHub

Uh oh!

ext/standard: applied fixers to improve test robustness - #23136

ext/standard: applied fixers to improve test robustness#23136NickSdot wants to merge 3 commits intophp:masterphp/php-src:masterfrom NickSdot:test/hardening/ext-standardNickSdot/php__php-src:test/hardening/ext-standardCopy head branch name to clipboard

Conversation

NickSdot commented Aug 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NickSdot commented Aug 10, 2026

Uh oh!

Girgias left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NickSdot commented Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ext/standard: applied fixers to improve test robustness#23136
NickSdot wants to merge 3 commits into
php:masterfrom
NickSdot:test/hardening/ext-standard

NickSdot commented Aug 8, 2026 •
edited
Loading