FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Zend: Improved test by NickSdot · Pull Request #23179 · php/php-src · GitHub

/ php-src Public

Zend: Improved test - #23179

Merged
Girgias merged 1 commit into
php:masterfrom
NickSdot:bb0ab98-nit
Aug 22, 2026
Merged

Zend: Improved test#23179
Girgias merged 1 commit into
php:masterfrom
NickSdot:bb0ab98-nit

Conversation

NickSdot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Follow up to #23123.

NickSdot marked this pull request as ready for review August 9, 2026 14:32

Copy link
Copy Markdown
Contributor Author

@LamentXU123 here is no maintainer; if you feel like... :)

(if you don't want me to tag you for these please let me know)

Copy link
Copy Markdown
Member

Since there are clear previous similar PR being merged. I am very fine of these sort of PRs. You can automatically count an approval from me in these PRs.
But I don't think I have a say on these files. It is dangerous to have someone deciding whether to merge a PR or not into a code base that they have no idea of. Considering you are "fixing" one of David's tests, I think his approval is way more important and persuasive than me.
Also never mind to @ me in your future PRs :) but only when you think in most cases I can provide reliable help, or the best thing I can do for you is to request review from whom I biased-ly trusted in.

Girgias merged commit 1dfd465 into php:master Aug 22, 2026
17 of 18 checks passed
NickSdot deleted the bb0ab98-nit branch August 22, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL