ext/sockets: socket_cmsg_space() returns int, never null - #23345
Merged
devnexen merged 3 commits intoAug 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The nullable return type dates from the stub introduction, when the error paths were warnings followed by a bare return. PHP 8.0 turned them into ValueError, so every exit is now either RETURN_LONG or RETURN_THROWS.
NickSdot
reviewed
Aug 18, 2026
Comment thread
ext/sockets/tests/socket_cmsg_space_return_type.phpt
Outdated
Co-authored-by: NickSdot <32384907+NickSdot@users.noreply.github.com>
Copy link
Copy Markdown
Member
|
You just need an UPGRADING entry but LGTM otherwise |
Sorry, something went wrong.
devnexen
approved these changes
Aug 19, 2026
Copy link
Copy Markdown
Member
|
are you able to merge yourself btw ? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
socket_cmsg_space() is declared ?int, but the nullable return is unreachable.
The stub was written when each failure was a php_error_docref() warning followed by a bare return;, which yields null. PHP 8.0 converted those to ValueError, removing every null exit path. The declaration was not updated.
Every exit is now either RETURN_LONG or RETURN_THROWS. Narrowing ?int to int is a subtype change; no valid call is affected.