docs: Internals Book improvements (07) - #23374
Draft
NickSdot wants to merge 19 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- replaced obsolete prototypes and external MySQL example with current stream contracts
- removed zend_parse_parameter() which was removed on 2026-08-10 (see UPGRADING.INTERNALS). - corrected variadic argument ownership/types.
- removed obsolete php 5 build system - corrected PHP_NEW_EXTENSION signature and C++ setup
- replaced obsolete PHP 5 example with the current SAPI callback contract - rewrote things
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #23368 (01), #23369 (02), #23370 (03), #23371 (04), #23372 (05), #23373 (06)
This PR gets the extensions contents from docs-old in order. It removes obsolete and clearly userland targeting stuff which is not relevant to the internals book. Diff to 06: NickSdot/php__php-src@docs/restructure-06...docs/restructure-07
Important:
Personally I think unbundled extensions have nothing todo with the internals book. It should live in the actual PHP Docs. However, it was part of the docs-old and I didn't want to decide on my own whether to remove the "Unbundled Extensions" page or not. A decision is needed.
Preview
Branch: https://nicksdot.github.io/docs-restructure-07/
Final: https://nicksdot.github.io/docs-restructure-final/