FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ext/gd: Add ZPP specifiers for array|float parameters by LamentXU123 · Pull Request #23384 · php/php-src · GitHub

/ php-src Public

ext/gd: Add ZPP specifiers for array|float parameters - #23384

Merged
LamentXU123 merged 1 commit into
php:masterfrom
LamentXU123:zpp
Aug 20, 2026
ConversationCommits (1)ChecksFiles changed
Merged

ext/gd: Add ZPP specifiers for array|float parameters#23384
LamentXU123 merged 1 commit into
php:masterfrom
LamentXU123:zpp

Conversation

LamentXU123 commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Follow-up #23356 (comment)_ cc @Girgias

Girgias commented Aug 19, 2026

Copy link
Copy Markdown
Member

I was thinking a custom one for the GD extension defined in the GD extension. As I don't think any other extension is going to utilize this.

LamentXU123 marked this pull request as draft August 19, 2026 15:34
LamentXU123 changed the title Zend: Add ZPP specifiers for array|float parameters ext/gd: Add ZPP specifiers for array|float parameters Aug 19, 2026
LamentXU123 marked this pull request as ready for review August 19, 2026 15:43
LamentXU123 requested a review from devnexen as a code owner August 19, 2026 15:43

LamentXU123 commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

Either way make sense to me.

Also I am aware the old test file doesn't test exception types. Don't need to change them in this PR if we want to change them we can do it in bulk.

Girgias approved these changes Aug 19, 2026
View reviewed changes

Girgias left a comment •
edited by LamentXU123
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor nit but LGTM

Comment thread ext/gd/gd.c Outdated
Comment thread ext/gd/gd.c

if ((tmp = zend_hash_str_find(Z_ARRVAL_P(options), "x", sizeof("x") - 1)) != NULL) {
if ((tmp = zend_hash_str_find(options, "x", sizeof("x") - 1)) != NULL) {
x = zval_get_double(tmp);

Girgias Aug 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Future PR: Ideally this should use a stricter variant as tmp could be an object of an array and still pass.

LamentXU123 merged commit dcce345 into php:master Aug 20, 2026
18 checks passed
php deleted a comment from ftps3rver Aug 21, 2026
LamentXU123 mentioned this pull request Aug 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Girgias Girgias approved these changes
devnexen Awaiting requested review from devnexen devnexen is a code owner

Assignees

No one assigned

Labels

Extension: gd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL