FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tls fix by rlerdorf · Pull Request #19 · php/setup-php-sdk · GitHub

This repository was archived by the owner on Apr 9, 2026. It is now read-only.

Repository navigation

tls fix - #19

Open
rlerdorf wants to merge 2 commits into
mainfrom
fix/invoke-webrequest-tls
Open

rlerdorf wants to merge 2 commits into
mainfrom
fix/invoke-webrequest-tls

Conversation

rlerdorf commented Apr 3, 2026

Copy link
Copy Markdown
Member
  • Adds the same TLS 1.2/1.3 enforcement that was already applied to determine-revision.ps1 in v0.12
  • Adds -UseBasicParsing to all 5 Invoke-WebRequest calls.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Updates the action’s PowerShell runner script to enforce modern TLS protocols and make Invoke-WebRequest calls compatible with older Windows PowerShell environments.

Changes:

  • Enforce TLS 1.2/1.3 via ServicePointManager.SecurityProtocol.
  • Add -UseBasicParsing to all Invoke-WebRequest calls (5 total) to avoid IE/DOM dependencies in Windows PowerShell.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread run.ps1 Outdated
rlerdorf requested a review from cmb69 April 3, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL