Allow standard to be selected in composer.json - #1
Conversation
Sorry, something went wrong.
schlessera
left a comment
There was a problem hiding this comment.
Hey @NickWilde1990, thanks for the PR!
I did a review and have a few nitpicks. But I agree with the approach and would like to merge this once we can take care of the few change requests.
Sorry, something went wrong.
| @@ -1 +1,2 @@ | |||
| /vendor/ | |||
| /.idea/ | |||
There was a problem hiding this comment.
This ignore should go into your global gitignore list, as it is not a direct artifact of the project, but rather a detail of your personal environment.
Sorry, something went wrong.
| WPCS provides 5 different coding standards (`WordPress-VIP`, `WordPress`, | ||
| `WordPress-Extra`, `WordPress-Docs` and `WordPress-Core`). By default this uses | ||
| `WordPress-Extra`. If you want to use another one of the standards, you can | ||
| specify it in your project's composer.json's `extra` key: |
There was a problem hiding this comment.
Reorder for readability
| specify it in your project's composer.json's `extra` key: | |
| specify it in the `extra` key of your project's `composer.json` file: |
Sorry, something went wrong.
|
|
||
| echo 'Running PHP CodeSniffer in ' . $this->root . PHP_EOL; | ||
| $sniffer = new PHP_CodeSniffer_CLI(); | ||
| @$config = $this->getExtraKey('php-composter-phpcs-wpcs', [ |
There was a problem hiding this comment.
Please avoid the "shut-up" operator (@ ). The getExtraKey() already verifies that the key does indeed exist and falls back to the value you provide if not. Any other error should either be dealt with separately, or bubble up because it might be pointing to a bigger issue.
| @$config = $this->getExtraKey('php-composter-phpcs-wpcs', [ | |
| $config = $this->getExtraKey('php-composter-phpcs-wpcs', [ |
Sorry, something went wrong.
|
|
||
| ob_start(); | ||
| $numErrors = $sniffer->process(array('standard' => 'WordPress-Extra', 'files' => $files)); | ||
| $numErrors = $sniffer->process([ |
There was a problem hiding this comment.
Did you think about merging the $files into the $config array here? This way, one could even pass other PHPCS/WPCS settings through the configuration in composer.json. Not sure there's much that makes sense, though...
Sorry, something went wrong.
No description provided.