FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: allow creating PRedis with a client by Iandenh · Pull Request #1389 · php-enqueue/enqueue-dev · GitHub

feat: allow creating PRedis with a client - #1389

Open
Iandenh wants to merge 1 commit into
php-enqueue:masterfrom
Iandenh:create-predis-with-client
Open

feat: allow creating PRedis with a client#1389
Iandenh wants to merge 1 commit into
php-enqueue:masterfrom
Iandenh:create-predis-with-client

Conversation

Iandenh commented May 19, 2025

Copy link
Copy Markdown

This pull request introduces the ability to create a PRedis instance using an already initialized Predis\Client. A new static method createWithClient has been added to facilitate this functionality.

Use Case
If a user already has a configured Predis\Client instance, they can now pass it directly to the PRedis class. This avoids the need to reconfigure the client or duplicate configuration logic. For example, I want to pass through enqueue because I have a predis client configured with Sentinel.

Changes

  1. Added a check in the constructor to accept a client key in the configuration array. If provided, it validates that the value is an instance of Predis\Client and uses it directly.
  2. Added a static method createWithClient(Client $client): self to simplify the creation of a PRedis instance with an existing Predis\Client.

Example Usage

use Predis\Client;
use Enqueue\Redis\PRedis;

$predisClient = new Client(['host' => '127.0.0.1', 'port' => 6379]);
$predis = PRedis::createWithClient($predisClient);

// Pass the PRedis instance to the RedisConnectionFactory
$connectionFactory = new RedisConnectionFactory($predis);

// Get the RedisContext
$redisContext = $connectionFactory->createContext();

Iandenh force-pushed the create-predis-with-client branch from 0335653 to 9f502fc Compare May 20, 2025 04:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL