FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Make serializer configurable via YAML configuration by lenchester · Pull Request #1390 · php-enqueue/enqueue-dev · GitHub

/ enqueue-dev Public

feat: Make serializer configurable via YAML configuration - #1390

Open
lenchester wants to merge 3 commits into
php-enqueue:masterfrom
lenchester:feature/serializer-replaceable
ConversationCommits (3)ChecksFiles changed
Open

feat: Make serializer configurable via YAML configuration#1390
lenchester wants to merge 3 commits into
php-enqueue:masterfrom
lenchester:feature/serializer-replaceable

Conversation

lenchester commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown

This change enables users to specify custom serializers with configuration
options in their Enqueue bundle YAML configuration, improving flexibility
when working with different message formats.

  • Add support for configuring serializers through YAML in RdKafkaContext
  • Allow serializer specification as a class name, array with options, or instance

feat: Make serializer configurable via YAML configuration
af27b52 
- Add support for configuring serializers through YAML in RdKafkaContext
- Allow serializer specification as a class name, array with options, or instance
Steveb-p reviewed May 20, 2025
View reviewed changes
Comment thread pkg/rdkafka/RdKafkaContext.php Outdated
Add fallback to JsonSerializer in configureSerializer
5559723 
- Ensures robustness by providing a default serializer
- Refactoring
lenchester requested a review from Steveb-p May 26, 2025 08:19
Steveb-p approved these changes May 26, 2025
View reviewed changes
Comment thread pkg/rdkafka/RdKafkaContext.php
Comment thread pkg/rdkafka/Tests/RdKafkaContextTest.php
lenchester requested a review from Steveb-p July 1, 2025 12:54

lenchester commented Jul 23, 2025

Copy link
Copy Markdown
Author

@Steveb-p can you review the PR?

lenchester commented Jul 23, 2025

Copy link
Copy Markdown
Author

Hmm, I’m not sure whether the error was caused by my changes.

Steveb-p commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Hmm, I’m not sure whether the error was caused by my changes.

Seems like it was a one-off failure in one job in tests.

GhassenRjab commented Mar 17, 2026

Copy link
Copy Markdown

Hey,
Thank you for working on this!

I am working in a Symfony app where Kafka is configured only with yaml files (enqueue and messenger).

I hope this feature gets added soon !

In the meantime, how can I configure a custom serializer without yaml? Can you help me please?

ovovov219-hash commented Apr 17, 2026

Copy link
Copy Markdown

Hi team, thank you for implementing this feature! Would it be possible to cut a new release with it? We’re currently blocked on this. Appreciate your work on this.

ovovov219-hash commented Apr 24, 2026

Copy link
Copy Markdown

@makasim Is it possible to release a new version? Thank you.

lenchester commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

This PR is a bit stale. Is there anything I could help to get it merged and released? @makasim

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Steveb-p Steveb-p approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL