Restore a phpdoc - #84
Merged
Seldaek merged 1 commit intoSep 11, 2024
Merged
Seldaek merged 1 commit into
Seldaek merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
v3.0.1 removed this line at php-fig@79dff0b#diff-ece1cc9e2cbefb0d1c511f88ab22703e9a402b9ca071df66704f1106c1433ad4L116 (in PR php-fig#80), however it isn't covered by a typehint so broke static analysis checks in consuming applications/packages using this interface
Jean85
approved these changes
Sep 9, 2024
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Since arguments cannot be restricted in classes implementing this interface, I'm 👍 with this revert: since you can't change the declaration, silencing the "this is mixed, you should restrict it" should be the way to go.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Yup, makes sense. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.0.1 removed this line at 79dff0b#diff-ece1cc9e2cbefb0d1c511f88ab22703e9a402b9ca071df66704f1106c1433ad4L116 (in PR #80), however it isn't covered by a typehint so broke static analysis checks in consuming applications/packages which implement this interface