adjust to integration tests 4 and modernize phpunit usage - #91
Merged
dbu merged 1 commit intoDec 9, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dbu
marked this pull request as draft
December 9, 2025 10:47
dbu
commented
Dec 9, 2025
Comment thread
composer.json
Outdated
dbu
force-pushed
the
integration-tests-4
branch
from
f5711a3 to
ea6f25b
Compare
December 9, 2025 10:54
dbu
force-pushed
the
integration-tests-4
branch
from
ea6f25b to
fff16e0
Compare
December 9, 2025 12:01
dbu
marked this pull request as ready for review
December 9, 2025 12:02
xabbuh
reviewed
Dec 10, 2025
Comment thread
tests/Unit/ClientTest.php
|
|
||
| $createHeaders = new \ReflectionMethod(Client::class, 'createHeaders'); | ||
| $createHeaders->setAccessible(true); | ||
| if (PHP_VERSION_ID < 80100) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
we can remove this entirely too
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
dang. i removed it in the other places but missed this one.
#92
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
test with the new major version of integration tests.