FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP: Start version 2 with some cleanups by dbu · Pull Request #34 · php-http/mock-client · GitHub

/ mock-client Public

WIP: Start version 2 with some cleanups - #34

Open
dbu wants to merge 1 commit into
1.xfrom
upgrade-version-2
ConversationCommits (1)ChecksFiles changed
Open

WIP: Start version 2 with some cleanups#34
dbu wants to merge 1 commit into
1.xfrom
upgrade-version-2

Conversation

dbu commented Dec 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets BC breaking changes from #29
Documentation -
License MIT

What's in this PR?

Some BC breaking changes that clean up the mock client. To be merged when we want to start with version 2.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • no documentation changes needed

TODO

dbu commented Dec 30, 2018
View reviewed changes
Comment thread src/Client.php
dbu force-pushed the upgrade-version-2 branch from b5a5ca3 to ac3d749 Compare December 30, 2018 12:25
dbu commented Dec 30, 2018
View reviewed changes
Comment thread src/Client.php Outdated
class Client implements HttpClient, HttpAsyncClient
{
use HttpAsyncClientEmulator;
use VersionBridgeClient;

dbu Dec 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

we bump to only version 2 of httplug

Nyholm commented Dec 30, 2018

Copy link
Copy Markdown
Member

Why do you want to release a new major version of this client?

dbu commented Dec 30, 2018

Copy link
Copy Markdown
Contributor Author

i don't want to do that now, just wanted to keep the cleanups that we agreed are useful but are BC break. i don't intend to merge this anytime soon.

dbu added this to the 2.0 milestone Jan 20, 2019

dbu commented Jan 27, 2019

Copy link
Copy Markdown
Contributor Author

as per discussion in #36 i want to merge this soonish. does that change if we want to drop httplug 1 support? the cost of supporting both is low and i think there would be value in keeping that so that libraries can test with both httplug 1 and 2 for a while.

dbu mentioned this pull request Feb 23, 2019
Closed

Taluu commented Sep 11, 2019

Copy link
Copy Markdown

Any update on this PR ? :}

dbu commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

i did not find the time to continue on this. if you want to wrap things up, more than happy to review things ;-)

Taluu commented Sep 12, 2019

Copy link
Copy Markdown

I'll give it a try whenever I get some time (not right now...). Do not wait on me though 😆

dbu force-pushed the upgrade-version-2 branch from 98b68eb to 37707f4 Compare August 25, 2021 07:05
dbu force-pushed the upgrade-version-2 branch from 37707f4 to 3f6d430 Compare August 25, 2021 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

Provide psr/http-client-implementation in composer.json

3 participants

Back | FazBrowse Home | New Git URL