FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve documentation for 0.4 release by wachterjohannes · Pull Request #2 · php-task/docs · GitHub

/ docs Public

Improve documentation for 0.4 release - #2

Merged
danrot merged 1 commit into
masterfrom
enhancement/doc
Dec 6, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Improve documentation for 0.4 release#2
danrot merged 1 commit into
masterfrom
enhancement/doc

Conversation

wachterjohannes commented Dec 5, 2016

Copy link
Copy Markdown
Member

This PR improves documentation for 0.4 release

wachterjohannes force-pushed the enhancement/doc branch 3 times, most recently from 69190d4 to 1295ff9 Compare December 5, 2016 09:10
danrot requested changes Dec 5, 2016
View reviewed changes
Comment thread components.rst Outdated

TaskScheduler
-------------
The ``TaskScheduler`` stores tasks and schedules Executions. Foreach tasks there

danrot Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

executions

danrot Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

foreach is not one english word, must be for each

danrot Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And it should be task instead of tasks

Comment thread components.rst Outdated
TaskScheduler
-------------
The ``TaskScheduler`` stores tasks and schedules Executions. Foreach tasks there
exists always on execution in the status ``planned``, ``running``. If the task

danrot Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

exactly one execution, or should that say something else?

Comment thread components.rst Outdated
The ``TaskScheduler`` stores tasks and schedules Executions. Foreach tasks there
exists always on execution in the status ``planned``, ``running``. If the task
will only one time it only get one execution at all. For recurring tasks the
execution will always generated for the next run time.

danrot Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For recurring tasks a new execution will be generated when the old one is completed.?

Comment thread components.rst Outdated
- ``workload``: the workload will be passed to the handler
- ``intervall``:
- ``firstExecution``:
- ``lastExecution``:

danrot Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would write another short explanation or remove the colons.

wachterjohannes commented Dec 5, 2016

Copy link
Copy Markdown
Member Author

@danrot fixed

danrot merged commit 16b8ff9 into master Dec 6, 2016
danrot deleted the enhancement/doc branch December 6, 2016 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

danrot danrot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL