Provide the 'TaskExecution' object in the handle method - #34
Open
smalot wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
wachterjohannes
requested changes
Apr 18, 2017
wachterjohannes
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
thanks for contribution. may i ask where you use this library?
Sorry, something went wrong.
Comment thread
src/Task/Runner/TaskRunner.php
|
|
||
| try { | ||
| return $handler->handle($execution->getWorkload()); | ||
| return $handler->handle($execution->getWorkload(), $execution); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This would lead into an "optional" argument? I would prefer a solution which the execution exists also in the interface. it is a BC-break but ok when you change this PR to develop.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@smalot I have thought deeper about this feature and I think your solution is a good way to keep BC. Could you please update this PR? I would like to release 1.1 soon. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the #33