Add support for symfony 7 and doctrine collections 2 - #49
Merged
wachterjohannes merged 9 commits intoJul 16, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
tests/Unit/Runner/TaskRunnerTest.php
Comment on lines
+87
to
+88
| $this->taskExecutionRepository->save($executions[0])->willReturnArgument(0)->shouldBeCalledTimes(3); | ||
| $this->taskExecutionRepository->save($executions[1])->willReturnArgument(0)->shouldBeCalledTimes(3); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
CI failing since: #47
Sorry, something went wrong.
Comment thread
tests/Unit/Runner/TaskRunnerTest.php
Comment on lines
+121
to
+122
| $this->taskExecutionRepository->save($executions[0])->willReturnArgument(0)->shouldBeCalledTimes(3); | ||
| $this->taskExecutionRepository->save($executions[1])->willReturnArgument(0)->shouldBeCalledTimes(3); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
CI failing since: #47
Sorry, something went wrong.
96 tasks
alexander-schranz
force-pushed
the
feature/deps-updates
branch
from
0df2d03 to
ff423c1
Compare
July 16, 2024 10:18
alexander-schranz
force-pushed
the
feature/deps-updates
branch
from
4aee689 to
56c29a6
Compare
July 16, 2024 10:25
Comment thread
.github/workflows/test-application.yaml
| - php-version: '8.3' | ||
| coverage: 'true' | ||
| - php-version: '8.4' | ||
| composer-flags: '--ignore-platform-reqs' |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
can be removed as soon as prophecy supports 8.4 officially: https://github.com/phpspec/prophecy/blob/f9e07be0992e7bf1cad210829055b99318df142f/composer.json#L21 but mostly it takes some time.
Sorry, something went wrong.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should add support for the latest symfony and latest doctrine collections version.
It also updates dev dependencies to PHPUnit 11 and also tests PHP 8.4.