FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enhance doctrine compatability by martinlagler · Pull Request #52 · php-task/php-task · GitHub

Enhance doctrine compatability - #52

Merged
wachterjohannes merged 2 commits into
php-task:masterfrom
martinlagler:enhancement/doctrine-compatibility
Jan 22, 2026
Merged

Enhance doctrine compatability#52
wachterjohannes merged 2 commits into
php-task:masterfrom
martinlagler:enhancement/doctrine-compatibility

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

wachterjohannes self-requested a review January 20, 2026 10:37
wachterjohannes changed the title Enhancement/doctrine compatibility Enhance doctrine compatability Jan 22, 2026
wachterjohannes merged commit d6fab02 into php-task:master Jan 22, 2026
1 check passed
alexander-schranz pushed a commit that referenced this pull request May 19, 2026
…#54)

* Fix scheduleTask DateTime contract & restore tests

- TaskScheduler::scheduleTask now converts the \DateTime returned by
  Cron\CronExpression::getNextRunDate() to \DateTimeImmutable before
  calling TaskExecutionRepositoryInterface::create(), which contractually
  requires \DateTimeImmutable. Without this, every cron-driven schedule
  fails with a TypeError when the repository enforces the parameter type.
- TaskExecution::getResult() returns null when the result column was
  never set, instead of false (unserialize(null) === false in PHP 8).
- Repair pre-existing syntax errors ("new \\DateTimeImmutable))" and
  "new \\DateTimeImmutable)'...')") that were left in the test suite by
  the sed-based DateTime → DateTimeImmutable migration in #52, which
  made the whole tests/Unit/Execution and tests/Unit/Storage suites
  un-loadable.
- Update remaining tests that still called the removed findAll() method
  to use findAllPaginated(1).

* Update CI runner to ubuntu-22.04

ubuntu-20.04 has been retired; jobs hang waiting for a runner. See:
https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/

* Address Copilot review

- TaskExecutionInterface::getResult() PHPDoc now documents the null
  return possibility introduced by the unset-result fix.
- Rename leftover testFindAll() methods to testFindAllPaginatedUnbounded()
  so the test name matches the API being exercised.

* Stop tracking phpunit result cache

Accidentally included in the previous commit; add it to .gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL