This repository was archived by the owner on Mar 6, 2022. It is now read-only.
IndexerHandler: use ProgressNotifier - #51
Open
camilledejoye wants to merge 1 commit into
Open
camilledejoye wants to merge 1 commit into
camilledejoye wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
It's fine to break BC here this isn't a reusable package |
Sorry, something went wrong.
dantleech
approved these changes
Sep 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on phpactor/language-server-extension#23
Make use of the new ProgressNotifier in the IndexHandler.
@dantleech I introduced a BC break by adding the new dependency.
Do you prefer that I handle it gracefully and trigger a depreciation if the service is not provided ?
It works on my side, the only annoying thing is that the last message disappear right away but ti's a client configuration issue IMO and it should not prevent us from using this feature on our side.