gh-3022: Explictly specify byte order - #3033
Merged
dantleech merged 2 commits intoMar 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
If ext-mbstring is not installed, then https://github.com/symfony/polyfill-mbstring will take over. The polyfill uses `iconv` There is an off-by-one issue that happens when the ext-mbstring is not enabled. `mbstring` outputs UTF-16BE (first in screenshot) and `iconv` outputs UTF-16LE and also adds BOM (fffe). By explicitly specifying the byte order we remove the ambiguity.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Phpactor Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 1e7aa03 | Previous: d4c868b | Ratio |
|---|---|---|---|
| ClassMemberCompletorBench::benchComplete | 162825.9 μs (± 1.12%) | 10590.8 μs (± 3.36%) | 15.37 |
| WorseLocalVariableCompletorBench::benchComplete | 22067.6 μs (± 0.93%) | 2363.7 μs (± 2.17%) | 9.34 |
| LexerBench::benchLex | 1350 μs (± 0%) | 615 μs (± 0%) | 2.20 |
| DiagnosticsBench::benchDiagnostics | 809022.6 μs (± 0.47%) | 71287.2 μs (± 0.79%) | 11.35 |
This comment was automatically generated by workflow using github-action-benchmark.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ext-mbstring is not installed, then
polyfll-mbstring will take over. The polyfill uses iconv.
There is an off-by-one issue that happens when the ext-mbstring is not enabled.
mbstring outputs UTF-16BE (first in screenshot) and iconv outputs UTF-16LE and also adds BOM (fffe).
By explicitly specifying the byte order we remove the ambiguity.
thanks @zobo for finding this. fixes #3022