FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[ticket/11979] Add ability to create dropdown menu to prosilver by cyberalien · Pull Request #1829 · phpbb/phpbb · GitHub

/ phpbb Public

[ticket/11979] Add ability to create dropdown menu to prosilver - #1829

Merged
nickvergessen merged 2 commits into
phpbb:developfrom
cyberalien:ticket/11979
Dec 6, 2013
ConversationCommits (2)ChecksFiles changed
Merged

[ticket/11979] Add ability to create dropdown menu to prosilver#1829
nickvergessen merged 2 commits into
phpbb:developfrom
cyberalien:ticket/11979

Conversation

cyberalien commented Oct 27, 2013

Copy link
Copy Markdown
Contributor

EXreaction commented Nov 2, 2013

Copy link
Copy Markdown
Contributor

Will we be using this for anything?

cyberalien commented Nov 2, 2013

Copy link
Copy Markdown
Contributor Author

Yes. prototech asked for it, I also want to switch notifications to this framework instead of duplicating code, users and mod authors will want to create their own menus

prototech commented Nov 2, 2013

Copy link
Copy Markdown
Contributor

I implement something similar in this PR #1773, but since Arty already added pretty much the same thing that would just create duplicated code. So, I asked him to make his implementation more extensible so that I could use it instead.

prototech mentioned this pull request Nov 9, 2013
Merged
nickvergessen reviewed Nov 9, 2013
View reviewed changes
Comment thread phpBB/styles/prosilver/theme/common.css

nickvergessen Nov 9, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As per IRC, prototech and me think most items that will use the dropdown are going to be inline, so we might add display: inline-block; here

cyberalien Nov 19, 2013

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why? Dropdown can be added to inline element as well. There is no reason to change display mode for trigger, if element that triggers dropdown must be inline-block then it should be set by styling of that particular element, not for all items that trigger dropdown menu.

prototech commented Nov 9, 2013

Copy link
Copy Markdown
Contributor

The dropdown should have a max height and switch to a scrollbar once it goes above it.

prototech mentioned this pull request Nov 10, 2013
Merged
1 task

cyberalien commented Nov 19, 2013

Copy link
Copy Markdown
Contributor Author

@prototech Added max-height and vertical scrollbar.

cyberalien commented Nov 19, 2013

Copy link
Copy Markdown
Contributor Author

Also rebased on recent develop

prototech commented Nov 20, 2013

Copy link
Copy Markdown
Contributor

Part of the content seems to go under the scrollbar. See the screenshot below. The full text is "Dropdown item #1"
http://ubuntuone.com/1opgk23313f02EE5o60cPV

nickvergessen commented Dec 3, 2013

Copy link
Copy Markdown
Contributor

@cyberalien bump? :)

nickvergessen merged commit be3bab4 into phpbb:develop Dec 6, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL