FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Css/buttons by neufke · Pull Request #1977 · phpbb/phpbb · GitHub

/ phpbb Public

Css/buttons - #1977

Closed
neufke wants to merge 4 commits into
phpbb:developfrom
neufke:css/buttons
Closed

Css/buttons#1977
neufke wants to merge 4 commits into
phpbb:developfrom
neufke:css/buttons

Conversation

neufke commented Jan 31, 2014

Copy link
Copy Markdown
Contributor

Changing the image based mini-buttons to css based buttons.

Changing the mini buttons from image to css
CSS-ing the mini buttons.

TICKET-ID

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

??? what is this? use an image?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

svg as part of css is supported by all browsers (except IE 8 and below and android 2.3 and below), gives a perfect gradient, is small, scalable and completely according to w3c... ;-)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I ment the base64 ;) can' you include the file instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@nickvergessen: ok, one of the svg as an aexample added to this thread. You can see what is in each and every file if you base64_decode the string in the css...

But i am a bit confused as to why you should want an image file of the background if the entire point was to get rid of all the fixed images...

check newly created ticket: http://tracker.phpbb.com/browse/PHPBB3-12155

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

well using a svg is not what was the plan.
We don't do that for the big buttons aswell.

Copy link
Copy Markdown
Contributor

Please use 2 different PRs one for the edit, quote, x, IP buttons
and one for the profile contact icons.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

base64 image

Copy link
Copy Markdown
Contributor

Replaced by:
#2005
#2006

prototech closed this Feb 18, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL